[meta] Audit public test methods that return something and validate that it actually makes sense in each case

Created on 18 June 2024, 12 days ago

Problem/Motivation

In reviewing 📌 Add void return typehints to all test methods Active , we noticed there are any number of what appear to be public test methods that have return values.

Proposed resolution

  • Review these methods and validate whether they actually need to return something (and document why).
  • Where appropriate, if they are test helper methods, convert them to protected and then include them in the scope of 🌱 Add return typehints to protected test helper methods Active .
  • If the method doesn't actually need to return anything, simply remove the return value and add the appropriate void return typehint.

Remaining tasks

TBD

API changes

TBD

Release notes snippet

Probably not, but TBD.

🌱 Plan
Status

Active

Version

11.0 🔥

Component
PHPUnit  →

Last updated about 19 hours ago

Created by

🇺🇸United States xjm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024