- Issue created by @infojunkie
- First commit to issue fork.
- Status changed to Needs review
7 months ago 12:39pm 19 June 2024 - 🇮🇳India sarwan_verma
Hi @drunken monkey,
I have tested patch #3 and it is working fine. I have created a MR. Please review and verify it.
- Status changed to Fixed
7 months ago 2:53pm 22 June 2024 - 🇦🇹Austria drunken monkey Vienna, Austria
First off, you definitely should not use Drupal 9 anymore, that’s been EOL for over half a year now.
However, I see that that class also wasn’t included in Drupal 10.1.0, which we do want to support, so the MR is still valid.
Changes look also good, so, merged.
Thanks! -
drunken monkey →
committed 28fac57e on 8.x-1.x authored by
sarwan_verma →
Issue #3455534 by infojunkie, sarwan_verma, drunken monkey: Fixed...
-
drunken monkey →
committed 28fac57e on 8.x-1.x authored by
sarwan_verma →
- 🇨🇦Canada infojunkie Vancouver
Thanks for committing!
First off, you definitely should not use Drupal 9 anymore, that’s been EOL for over half a year now.
If you don't plan to support D9 in your module, it might make sense to remove it from the
core_version_requirement, otherwise members of the community would assume you are still supporting it. - 🇦🇹Austria drunken monkey Vienna, Austria
If you don't plan to support D9 in your module, it might make sense to remove it from the
core_version_requirement, otherwise members of the community would assume you are still supporting it.That’s not what I said, but increasing the requirement is probably still a good idea.
Automatically closed - issue fixed for 2 weeks with no activity.