- Issue created by @shashank5563
- Assigned to abhishek_virasat
- Issue was unassigned.
- Status changed to Needs review
7 months ago 9:57am 18 June 2024 - 🇮🇳India abhishek_virasat
@shashank5563, I have fixed the issue and created MR. please review it once.
- Status changed to Fixed
7 months ago 9:00am 19 June 2024 - 🇳🇱Netherlands johnv
Thanks, I will commit the attached patch, which is equivalent to the above soution.
I think this is a minor error, not a major one, since no site is broken, and the given test case (empty pm hour) will give an error message 'The time is incomplete. A value must be selected for hour.' anyway. - Status changed to Needs work
7 months ago 9:46am 20 June 2024 - 🇪🇸Spain plopesc Valladolid
@johnv I can confirm the bug and the error you mentioned "The time is incomplete. A value must be selected for hour." is not being triggered.
Instead, default value of 12 00 pm is saved, which is not accurate.
- Status changed to Fixed
7 months ago 10:29am 20 June 2024 - 🇳🇱Netherlands johnv
Above patch changes the check for correct filling of the time, sepecifically the empty hours field.
- 🇪🇸Spain plopesc Valladolid
Last patch also fixes 🐛 '00' minutes are considered as empty in OfficeHoursDateList::validateDateList Closed: duplicate
Adding for reference.
Automatically closed - issue fixed for 2 weeks with no activity.