- Issue created by @heddn
- Status changed to Needs work
6 months ago 3:21pm 18 June 2024 - Status changed to Needs review
6 months ago 3:57pm 18 June 2024 - heddn Nicaragua
Instead of duplicating the call to
isExternal
in both places just to return an exception, I opted for the already existing exception fromUrl::fromUri
to bubble up and only moved the logic check intoprocessOutbound
I tend to shy away from duplicate calls, especially when it entails mildly expensive regex calls on every single page. - heddn Nicaragua
The last commit reverts back to the previous approach.
cl_server
has anAbsolutePathProcessor
that executes for URL generation. Which proves that we can have internal URLs that are absolute by the time they get to GroupPathPrefixRepository::getGroupByInternalPath. Let's guard against that. -
gabesullice →
committed c160dfc7 on 1.0.x authored by
heddn →
Issue #3455128 by heddn, gabesullice: Call UrlHelper::isExternal before...
-
gabesullice →
committed c160dfc7 on 1.0.x authored by
heddn →
- Status changed to Fixed
6 months ago 3:50pm 20 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.