- Issue created by @dpi
- Issue was unassigned.
- Status changed to Needs review
10 months ago 12:59pm 17 June 2024 - 🇦🇺Australia dpi Perth, Australia
The pill markup adds quite large diffsize. Willing to do away with it and stick to a simplified version if we can keep the markup and layout/flexbox pieces, so we can potentially use the markup+selectors in extended/custom themes.
- 🇦🇺Australia dpi Perth, Australia
The code is looking less insane with this revision.
- First commit to issue fork.
- 🇨🇭Switzerland berdir Switzerland
Hi, thanks for this. It certainly looks much better, thanks for working on this. I discussed it a bit with a colleague, our thoughts:
* The colored pills text on background color is not accessible and especially green is barely readable. Based on our testing, I think I'd prefer to keep the text color black, then contrast is fine.
* It looks bigger on your screenshots, but on claro, the text is tiny and also on larger screens far off to the right:Thinking about it, I think the important parts are actually the status summary (the pills) and the buttons. the cache/execution time is not the most important thing to see at first glance. So maybe we could invert the position to what it is now? And instead of completely right aligned I think we should have the two the right just follow with a bit of margin? a quickfix is to not do a text align right, it's a somewhere in the middle then.
On text size, I prefer to have them in regular text size.
I even wondered about moving the cache/execution time info to after the table and not doing any flex at all. it is kind of related with the execute all button though.
Would then look something like this for me, but there might be better ways than my quick hacks, especially for the position. And instead of a pure css order, maybe we should rearrange the render array?
- 🇦🇺Australia dpi Perth, Australia
Hoping to revisit this with D11 upgrades, but that could end up being any time this year.