- Issue created by @pebosi
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
kim.pepper β made their first commit to this issueβs fork.
- Merge request !55#3454980 Update __sleep, __wakeup to work with latest Search API release β (Merged) created by kim.pepper
- Status changed to Needs review
5 months ago 9:51pm 17 June 2024 - π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
This is an issue because \Drupal\Core\DependencyInjection\DependencySerializationTrait::__sleep() and __wakeup() do not have support types in 10.2.x/10.3.x but they have been added in 11.x.
As PHP supports covariance, we can ensure our class implements the return types by overriding these methods and we can remove them when 10.x versions are no longer supported.
https://www.php.net/manual/en/language.oop5.variance.php
Adding return types should be done on the implementing classes first.
- π¦πΊAustralia kim.pepper πββοΈπ¦πΊSydney, Australia
Committed to 3.x and 2.x. Thanks!
-
kim.pepper β
committed b7c3c336 on 3.x
Issue #3454980 by kim.pepper, pebosi: Handle missing return type in...
-
kim.pepper β
committed b7c3c336 on 3.x
- Status changed to Fixed
5 months ago 9:55pm 17 June 2024 -
kim.pepper β
committed dab67587 on 2.x
Issue #3454980 by kim.pepper, pebosi: Handle missing return type in...
-
kim.pepper β
committed dab67587 on 2.x
Automatically closed - issue fixed for 2 weeks with no activity.