Contrib.social

CLI/Drush cannot do file checks directly

Open on Drupal.org →
Created on 16 June 2024, 7 months ago

Problem/Motivation

Because drush is usually running drupal directly important checks on files modification possibilities get no or often wrong results.
This is also related to ✨ "Safe file system permissions" should test the ownership of files and directories Closed: outdated .

Steps to reproduce

For example create a folder "test" in webroot and make is writable by the cli user itself and the webserver. The GUI webserver check detects it correctly but not drush.

Proposed resolution

The minimum we need is to know which system user e.g. it's posix uid is running the related webserver/php process. This can be provided by setting.local.php. Easier to use would be an own protected route only to be called via cli which just returns this uid and guid information. With this information we can do fast tests. Maybe easier to code but with the limitations of the webserver would be an option to run checks through a route.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Active

Version

3.0

Component

Code

Created by

🇩🇪Germany c-logemann Frankfurt/M, Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @c-logemann
  • Comment 7 months ago →
    🇩🇪Germany c-logemann Frankfurt/M, Germany

    Currently setServerData() is just returning null on cli usage (see also 🐛 Get server uid function return unexpected type null Active . This is avoids corrects tests but even if we just open it would get wrong values of the file owner and they would be store in state api.
    Even if the current code will not mess up with the state API storage and cli can get correct serverdata.- This only would be available after a successful check via GUI. Beside the basic auth problematic (see related issue) this cann not work on a fresh test system e.g. in CI-Workflow.

  • Comment 7 months ago →
    🇩🇪Germany c-logemann Frankfurt/M, Germany

    setServerData() is currently triggered via cron. This could be an interface to run cron via http request. But in CI situations cron isn't always wanted depending on the system needs.

  • Comment 3 months ago →
    🇺🇸United States smustgrave

    Hello @c-logemann since it's been a few months wonder if you want me to un-assign?

  • Comment 3 months ago →
    🇩🇪Germany c-logemann Frankfurt/M, Germany

    @smustgrave Sorry I was to busy in last time.I think we need an own route that can be triggered by drush also with basic auth credentials, see 🐛 Checks using sub requests with guzzle get wrong results in basic auth systems Active
    But please do not close the issue. When I finde some tie in winter I try to solve if nobody else steps in.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024