PHPunit Next Major pipeline failure

The tests of the previous minor fail because of a critical bug in the Book module that occurs on Drupal 10.2:
🐛 BookOutline" plugin does not exist Needs review

It would be nice if drupal/book is only used when on Drupal 11. So I searched for how to conditionally composer require something and I found this:
On https://stackoverflow.com/questions/51333587/php-composer-require-depend...

So I created a metapackage called "megachriz/drupalbook" and published it on GitHub and Packagist.
https://github.com/MegaChriz/drupalbook
https://packagist.org/packages/megachriz/drupalbook

Let's see if I did this correctly.

All tests are passing, I will check the code changes in a few days.

All changes looks good and great to see all the pipelines are passing without single warning.. great improvisation.

Only thing I'm concerned is about megachriz/drupalbook as version^1 consists of only drupal/core:^10 and version^2 consists of drupal/core:^11 and drupal/book:^1.0

Rest all looks perfectly in place.

With referring #5 I believe once book module fixes at bug then book issue for previous minor also get fixed and then we can get back to the drupal/book package, Correct me if I'm wrong!!

@ankitv18
Thanks for giving feedback!

Only thing I'm concerned is about megachriz/drupalbook as version^1 consists of only drupal/core:^10 and version^2 consists of drupal/core:^11 and drupal/book:^1.0

My idea behind this is: use drupal/book version 1 only on Drupal 11, else do not use drupal/book at all. Can you explain further what your concern is here?

With referring #5 I believe once book module fixes at bug then book issue for previous minor also get fixed and then we can get back to the drupal/book package, Correct me if I'm wrong!!

Yes, if 🐛 BookOutline" plugin does not exist Needs review gets fixed, we can stop using megachriz/drupalbook as dev dependency of Feeds and use drupal/book^1.0.1 instead.

alright then I guess this one is ready to move ahead ~~ marking this RTBC

@megachriz can we merge this and plan for Drupal 11 release: https://www.drupal.org/project/feeds/issues/3430449 📌 Automated Drupal 11 compatibility fixes for feeds Needs review

I think that August 29 would be a good date for the next release. I'd like to create releases for all Feeds related projects on the same day. The Feeds related projects that I maintain are:

• Feeds
• Feeds Extensible Parsers
• Feeds Tamper
• Tamper
• Feeds Textarea Fetcher
• Commerce Feeds

Commerce Feeds is not compatible with Drupal 11 yet in its dev version. That one requires 🐛 [D11] RouteNotFoundException thrown when viewing imported product variations Fixed to be fixed. I hope to finish that one and Commerce Feeds this Thursday. Then I need some time to write the release notes for each project.
Tamper and Feeds Textarea Fetcher look release ready. I did some basic testing for Feeds, Feeds Extensible Parsers and Feeds Tamper, but it would be good to test them on error handling too - because of the replacement of watchdog_exception(). And not every piece of code where watchdog_exception() was used is covered by tests. But I don't want to put too much time into testing either so the releases can still happen this month.

Alrighty!! I would suggest if we merge this issue then it would unblock the next major pipeline for all the other issues.
Issue#3468323 would also gets the complete green pipeline.

Recent changes in Drupal 11 dev caused tests to fail again, but I've fixed them. 😅

Merged the code.

@ankitv18
Unfortunately, while working on Commerce Feeds today, I found a new bug in Feeds that gives a warning on D10 and is disruptive on D11.
Therefore, I think it's not realistic anymore to do the releases on August 29. I won't have time this weekend to fix the bug.

The bug is that when an array is used for an unique target, Drupal 11 throws an InvalidQueryException.
Some details here: https://git.drupalcode.org/project/commerce_feeds/-/merge_requests/5/dif...

I hope to create a bug report for this early next week. I'm done for today.

Automatically closed - issue fixed for 2 weeks with no activity.