PHP CodeSniffer errors need review and cleanup

Created on 14 June 2024, 7 months ago

Gitlab pipelines are flagging formatting errors in some files. Attached is most recent output of issues to review and clean up where needed.

πŸ“Œ Task
Status

Active

Version

3.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States CarlyGerard

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

  • Issue created by @CarlyGerard
  • First commit to issue fork.
  • πŸ‡ΊπŸ‡ΈUnited States theMusician

    I have pushed a branch up that I have fixed all issues in src/, and phpcbf --standard=Drupal fixed in the translations directory. Translations are supplied by the Ableplayer project itself, so perhaps those should be excluded.

    If one runs phpcs --standard=Drupal . within the Ableplayer directory there are just a handful of errors to resolve within the /tests directory.

  • Pipeline finished with Failed
    13 days ago
    Total: 159s
    #392309
  • Pipeline finished with Failed
    13 days ago
    Total: 195s
    #392312
  • Pipeline finished with Failed
    13 days ago
    Total: 163s
    #392318
  • Pipeline finished with Failed
    13 days ago
    Total: 168s
    #392324
  • πŸ‡ΊπŸ‡ΈUnited States theMusician

    This branch, bronsem/code-cleanup, is now passing phpcs tests. https://git.drupalcode.org/issue/ableplayer-3454701/-/jobs/3976580

    Open to further improvements if any exist.

Production build 0.71.5 2024