- Issue created by @SnowCoder
- Status changed to Needs work
5 months ago 2:32pm 12 June 2024 - πΊπΈUnited States tim.tripp
I can produce the
fa-fw
problem but not the stripping of links in 1.1.0. The only causes I can think of for that are a caching issue or the Link plugin isn't enabled in your editor (a change from 1.0.0 was the Link plugin must be enabled to allow linkHref). How are you allowingtarget="_blank"
on your links? - Status changed to Active
5 months ago 3:20pm 12 June 2024 - π¨π¦Canada SnowCoder
Ok, glad the
fa-fw
problem isn't just me.
As for the stripping of links, here's a screenshot of my profile. As you can see, I have the Link plugin enabled.
Regarding thetarget="_blank"
, I mispoke. I didn't realize that wasn't working for me either anymore. - Status changed to Needs work
5 months ago 3:21pm 12 June 2024 - πΊπΈUnited States tim.tripp
Are you using a third-party contrib module for "Advanced Links"? The stock Link plugin doesn't seem to provide that.
- Status changed to Needs review
5 months ago 3:41pm 12 June 2024 - Merge request !8Issue #3454184: Fixes incorrect handling of multiple Font Awesome classes β (Merged) created by Unnamed author
- π¨π¦Canada SnowCoder
Ok, I tried the patch, cleared the cache and the original problem seemed to have been fixed. I can now use
fa-fw
without it being stripped.However, the anchor problem still persists where it strips out the following extra attributes in my one example:
target="_blank" title="Title text" aria-label="Aria label"
. - πΊπΈUnited States tim.tripp
I need to know how you're seeing "Advanced Links" because if you're using a contrib module to mess with links this is likely why I can't reproduce your issue with the links. I don't have "Advanced Links" on my installation. Also are you saying it just strips the attributes now, or is it still the entire link?
Thanks for verifying the
fa-fw
bug is fixed. - π¨π¦Canada SnowCoder
Apologies. Yes, I'm using Editor Advanced Link module β on my site.
Also, the attributes are the only thing being stripped now as the link does remain.
<a href="#" target="_blank" title="Title text" aria-label="Aria label"><i class="fa-brands fa-facebook fa-fw"> </i></a>
now becomes:
<a href="#"><i class="fa-brands fa-facebook fa-fw"> </i></a>
-
timurtripp β
committed 1a523626 on 1.x
Issue #3454184 by timurtripp, SnowCoder: Fixed width "fa-fw" class keeps...
-
timurtripp β
committed 1a523626 on 1.x
- πΊπΈUnited States tim.tripp
Great, can you open a separate issue for that one? I'll merge into the dev branch and mark this one as resolved as it relates to the multiple FA classes bug. Thanks for finding that one.
It looks like Drupal Media exhibits the same behavior of stripping the advanced link attributes so the issue isn't unique to icons. You may even try opening an issue in the Editor Advanced Link module to say that both the Drupal Media and Icon plugins are stripping the advanced link attributes when they are linked, maybe the contributors there can get to the bottom of what's happening.
- Status changed to Fixed
5 months ago 6:44pm 12 June 2024 - πΊπΈUnited States tim.tripp
Drupal Media seems better than Icon at preserving the
target="_blank"
specifically but always strips the other attributes liketitle
andaria-label
just like Icon. Not quite sure what's going on with their solution to this. -
timurtripp β
committed 1a523626 on 1.1.x
Issue #3454184 by timurtripp, SnowCoder: Fixed width "fa-fw" class keeps...
-
timurtripp β
committed 1a523626 on 1.1.x
Automatically closed - issue fixed for 2 weeks with no activity.