- Issue created by @phenaproxima
- Status changed to Needs review
7 months ago 12:27am 11 June 2024 - Status changed to RTBC
7 months ago 1:52am 11 June 2024 - π¦πΊAustralia sime Melbourne
Subjectively, everything is good about this. I have discussed with @acbramley just to make sure i'm not misreading anything the emerging practice of autowiring. Loaded everything locally, I can't see any reason not to RTBC this.
The only note is that this technically this is breaking BC - assuming other contrib projects actually use PB services, they would have to update some service references, since we don't add aliases to the old service IDs. I think a clean break is ok on the 2.0 branch.
- First commit to issue fork.
-
chrisfromredfin β
committed 8f633073 on 2.0.x authored by
phenaproxima β
Issue #3453808 by phenaproxima, sime, chrisfromredfin: Refer to services...
-
chrisfromredfin β
committed 8f633073 on 2.0.x authored by
phenaproxima β
- Status changed to Fixed
7 months ago 2:10pm 11 June 2024 - πΊπΈUnited States chrisfromredfin Portland, Maine
all cleanup, much more readable and simple. tested manually & automatically, and passing. Shipping it!
Automatically closed - issue fixed for 2 weeks with no activity.