Refer to services by their class/interface names, and autowire where possible

Created on 10 June 2024, 11 months ago
Updated 25 June 2024, 11 months ago

Problem/Motivation

Having "names" for services, like project_browser.installer, is old hat. The new way (which is conducive to autowiring) is to refer to services by their class or interface name. Let's do that, and adopt autowiring as much as possible, to get more in line with the modern way core is developed.

πŸ“Œ Task
Status

Fixed

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts

Live updates comments and jobs are added and updated live.
  • API clean-up

    Refactors an existing API or subsystem for consistency, performance, modularization, flexibility, third-party integration, etc. May imply an API change. Frequently used during the Code Slush phase of the release cycle.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @phenaproxima
  • Merge request !504Use new service naming, and autowire β†’ (Merged) created by phenaproxima
  • Pipeline finished with Canceled
    11 months ago
    Total: 239s
    #195947
  • Pipeline finished with Failed
    11 months ago
    Total: 432s
    #195951
  • Pipeline finished with Failed
    11 months ago
    #195952
  • Status changed to Needs review 11 months ago
  • πŸ‡ΊπŸ‡ΈUnited States phenaproxima Massachusetts
  • Pipeline finished with Success
    11 months ago
    Total: 436s
    #195953
  • Status changed to RTBC 11 months ago
  • πŸ‡¦πŸ‡ΊAustralia sime Melbourne

    Subjectively, everything is good about this. I have discussed with @acbramley just to make sure i'm not misreading anything the emerging practice of autowiring. Loaded everything locally, I can't see any reason not to RTBC this.

    The only note is that this technically this is breaking BC - assuming other contrib projects actually use PB services, they would have to update some service references, since we don't add aliases to the old service IDs. I think a clean break is ok on the 2.0 branch.

  • Pipeline finished with Skipped
    11 months ago
    #196459
  • First commit to issue fork.
  • Status changed to Fixed 11 months ago
  • πŸ‡ΊπŸ‡ΈUnited States chrisfromredfin Portland, Maine

    all cleanup, much more readable and simple. tested manually & automatically, and passing. Shipping it!

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024