- Issue created by @phenaproxima
- Status changed to Needs review
6 months ago 10:41pm 10 June 2024 - πΊπΈUnited States phenaproxima Massachusetts
This is needed for recipes to be properly supported, so although it doesn't block β¨ Create a source plugin that exposes recipes in the file system Active , it is a Starshot blocker.
- π¦πΊAustralia sime Melbourne
Reading the code, the changes make perfect sense to me, and the ActivateInterface is intuitive when you trace that through to ModuleActivator it's good DX. Obviously this is a pretty important ticket for abstracting things out and make installing recipes possible.
Big +1. Probably needs someone with longer experience with PB that me to RTBC.
That would allow us to get rid of the text below that says what to do if you don't have Drush.
Safe to keep it out of scope, but this is something that has niggled me for sure.
- π¦πΊAustralia sime Melbourne
Next positive reviewer, if no obvious issues, please RTBC to keep things rolling for the recipes work.
- First commit to issue fork.
-
bnjmnm β
committed 6e37fe91 on 2.0.x authored by
phenaproxima β
Issue #3453766: Activators should be responsible for generating project...
-
bnjmnm β
committed 6e37fe91 on 2.0.x authored by
phenaproxima β
- Status changed to Fixed
6 months ago 4:59pm 11 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.