Contrib.social

Service decorator must use the "inner" pattern

Open on Drupal.org →
Created on 10 June 2024, 6 months ago
Updated 12 July 2024, 4 months ago

Problem/Motivation

When used ion conjunction with a module like Access Unpublished, the access_check.latest_revision decorators do not properly use "inner" services to allow other decorators to run. This affects:

  • access_check.approve_latest_revision
  • access_check.view_approvals
  • access_check.access_approve_latest_revision
  • access_check.access_view_approvals

Steps to reproduce

Install Access Unpublished and try to view an unpublished node at node/[nid]/latest

Proposed resolution

Use inner service decorators properly. See https://symfony.com/doc/current/service_container/service_decoration.htm... and https://www.axelerant.com/blog/drupal-8-service-decorators for examples.

Set decoration_priority to 10.

Remaining tasks

Refactor decorators.

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇺🇸United States agentrickard Georgia (US)

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024