- Issue created by @aaron.ferris
- Assigned to nexusnovaz
- Issue was unassigned.
- Status changed to Needs review
11 months ago 2:00pm 8 June 2024 - 🇬🇧United Kingdom nexusnovaz
Hey, this should be ready for review. Please see MR !16
- 🇬🇧United Kingdom aaron.ferris
Thanks @NexusNovaz - looks good, something thats sprung to mind is that we will want the module to work as though these options are TRUE out of the box, given the way it worked before. We could add a default settings config to config/install, then an update hook to import this config for existing sites - effectively meaning with this change the module works the same as it does now, with the option for each part to be disabled as needed. Hope that makes sense.
- Status changed to Needs work
11 months ago 2:35pm 8 June 2024 - Status changed to Needs review
11 months ago 2:59pm 8 June 2024 - 🇬🇧United Kingdom nexusnovaz
Hey @aaron.ferris,
Thanks for that. Makes sense. Added config/install/menu_css_names.settings.yml file with the default settings and config/schema file for the settings. Since we will have these default settings, i've removed the
?? FALSE
from the settings form.Please could you review MR !16 again.
- 🇬🇧United Kingdom aaron.ferris
Thanks for this looks good, ive pushed some minor changes
- Updated the form labels, to be more descriptive
- Added a .menu
- Readme and hook_help updates
- Added an update hook, I don't think this is really needed but its nagging at me
Tested this with/without the config options and it works as id expect. Merging.
-
aaron.ferris →
committed 7d53bf7d on 2.0.x authored by
NexusNovaz →
Resolve #3453353 "Config form"
-
aaron.ferris →
committed 7d53bf7d on 2.0.x authored by
NexusNovaz →
- Status changed to Fixed
11 months ago 12:39pm 9 June 2024 - Status changed to Fixed
11 months ago 8:56am 12 June 2024