- Issue created by @bbrala
- Status changed to Needs review
7 months ago 11:42am 7 June 2024 - 🇳🇱Netherlands bbrala Netherlands
- đź‡đź‡şHungary Gábor Hojtsy Hungary
These don't seem to appear in the deprecation status info though? These two appear but they will not match the strpos() proposed:
Call to deprecated method loadRevision() of interface Drupal​\​Core​\​Entity​\​EntityStorageInterface. Deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use Drupal​\​Core​\​Entity​\​RevisionableStorageInterface::loadRevision instead.
Call to deprecated method deleteRevision() of interface Drupal​\​Core​\​Entity​\​EntityStorageInterface. Deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use Drupal​\​Core​\​Entity​\​RevisionableStorageInterface::deleteRevision instead.
Is deleteRevision not affected by the same situation?
- Status changed to Needs work
6 months ago 6:22am 12 June 2024 - đź‡đź‡şHungary Gábor Hojtsy Hungary
- 🇳🇱Netherlands bbrala Netherlands
Oops missed delte indeed. Same set.
Silly if I mistyped the strpos, will fix.
- đź‡đź‡şHungary Gábor Hojtsy Hungary
Yeah the "mistype" is the lack of method at the end of the strpos, the errors have the respective methods, while you match for
RevisionableStorageInterface instead
which does not appear as is. - Status changed to Needs review
6 months ago 1:25pm 4 July 2024 - đź‡đź‡şHungary Gábor Hojtsy Hungary
Ok I made a suggestion for what needed changing. Marking it "ignore" will still make it show up in the reported list in Upgrade Status but it will be lower priority. Is that intended? (Similar to issues in future Drupal versions).
- 🇳🇱Netherlands bbrala Netherlands
Yeah, report it, but then it wont hold back upgrades since the chance for it to actually be an issue is minimal.
-
Gábor Hojtsy →
committed bcca2006 on 4.x authored by
bbrala →
Issue #3453188 by bbrala, Gábor Hojtsy: Ingore loadRevision deprecation
-
Gábor Hojtsy →
committed bcca2006 on 4.x authored by
bbrala →
- Status changed to Fixed
6 months ago 8:11am 8 July 2024 Automatically closed - issue fixed for 2 weeks with no activity.