- Issue created by @sime
- Status changed to Needs review
7 months ago 3:05am 8 June 2024 - 🇦🇺Australia sime Melbourne
A small bump in phpstan to level 1, easy level to hit. If this is wanted and merged I'll check out level 2.
- Status changed to RTBC
7 months ago 11:39am 8 June 2024 - Status changed to Needs work
7 months ago 12:21am 10 June 2024 - 🇦🇺Australia sime Melbourne
Last change has revealed an ignore that is no longer needed.
- Status changed to Needs review
7 months ago 2:05am 10 June 2024 - 🇦🇺Australia sime Melbourne
Since last RTBC at #6 I
- turned on
reportUnmatchedIgnoredErrors - removed a stale ignore from
ProjectBrowserSourceExample - made the
/sveltejspath ignore more generic.
- turned on
- Status changed to RTBC
7 months ago 10:34am 10 June 2024 - 🇺🇸United States phenaproxima Massachusetts
Since ✨ Create a source plugin that exposes recipes in the file system Active is failing CI only due to intractable PHPStan problems, I think it makes sense to get this in first, so that we can adjust the baseline before merging that issue.
- 🇦🇺Australia sime Melbourne
Thanks for the quick RTBC @phenaproxima
Committer, please credit @mstrelan who kindly sanity checked me. - First commit to issue fork.
- Status changed to Fixed
7 months ago 6:30pm 10 June 2024 - 🇺🇸United States bnjmnm Ann Arbor, MI
Glad to see this spotted and addressed and working up from 1 seems like a good approach.
- Status changed to Downport
7 months ago 6:35pm 10 June 2024 - 🇺🇸United States phenaproxima Massachusetts
Thanks all! This needs to be ported to 2.0.x also.
- Status changed to Fixed
7 months ago 6:38pm 10 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.