Contrib.social

phpstan.neon.dist fixes - Get phpstan to level 1

Open on Drupal.org →
Created on 7 June 2024, 6 months ago
Updated 24 June 2024, 5 months ago

Problem/Motivation

Turns out the phpstan.neon.dist is not being used.
https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes...

I created this issue for that.
https://www.drupal.org/project/gitlab_templates/issues/3453100 →

Also, I don't think we should default to the core phpstan.neon as it has a LOT of historical workarounds (which is why it is not default in gitlab for contrib). This is the line we have (which isn't being used per above).
https://git.drupalcode.org/project/project_browser/-/blob/1.0.x/phpstan....

My proposal is to get get to a nice low level coverage (level 1 in this ticket) and then incrementally increase levels on other subsequent issues as desired.
We are currently level 0 https://git.drupalcode.org/project/gitlab_templates/-/blob/main/assets/p...

Steps to reproduce

Proposed resolution

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇦🇺Australia sime Melbourne

Live updates comments and jobs are added and updated live.
  • Starshot blocker

    A potential blocker for Drupal Starshot. More information: http://www.drupal.org/project/starshot

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @sime
  • Comment 6 months ago →
    🇦🇺Australia sime Melbourne
  • Comment 6 months ago →
    🇦🇺Australia sime Melbourne
  • Merge request !499PHPStan level to the stars. → (Merged) created by sime
  • Pipeline finished with Failed
    6 months ago
    Total: 403s
    #193278
  • Pipeline finished with Canceled
    6 months ago
    Total: 64s
    #193286
  • Pipeline finished with Failed
    6 months ago
    Total: 853s
    #193287
  • Pipeline finished with Failed
    6 months ago
    Total: 455s
    #193298
  • Pipeline finished with Failed
    6 months ago
    Total: 505s
    #193305
  • Pipeline finished with Success
    6 months ago
    Total: 383s
    #193315
  • Pipeline finished with Failed
    6 months ago
    Total: 480s
    #193347
  • Pipeline finished with Failed
    6 months ago
    Total: 422s
    #193366
  • Pipeline finished with Failed
    6 months ago
    Total: 470s
    #193392
  • Pipeline finished with Failed
    6 months ago
    Total: 514s
    #193685
  • Pipeline finished with Success
    6 months ago
    Total: 1507s
    #193747
  • Pipeline finished with Success
    6 months ago
    Total: 568s
    #194099
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    🇦🇺Australia sime Melbourne

    A small bump in phpstan to level 1, easy level to hit. If this is wanted and merged I'll check out level 2.

  • Pipeline finished with Success
    6 months ago
    Total: 382s
    #194106
  • Status changed to RTBC 6 months ago
  • Comment 6 months ago →
    🇺🇸United States phenaproxima Massachusetts

    I don't have a problem with this.

  • Comment 6 months ago →
    🇦🇺Australia sime Melbourne
  • Pipeline finished with Canceled
    5 months ago
    Total: 202s
    #195106
  • Pipeline finished with Failed
    5 months ago
    Total: 420s
    #195134
  • Status changed to Needs work 5 months ago
  • Comment 5 months ago →
    🇦🇺Australia sime Melbourne

    Last change has revealed an ignore that is no longer needed.

  • Pipeline finished with Success
    5 months ago
    Total: 510s
    #195154
  • Status changed to Needs review 5 months ago
  • Comment 5 months ago →
    🇦🇺Australia sime Melbourne

    Since last RTBC at #6 I

    • turned on reportUnmatchedIgnoredErrors
    • removed a stale ignore from ProjectBrowserSourceExample
    • made the /sveltejs path ignore more generic.
  • Status changed to RTBC 5 months ago
  • Comment 5 months ago →
    🇺🇸United States phenaproxima Massachusetts
  • Comment 5 months ago →
    🇺🇸United States phenaproxima Massachusetts

    Since ✨ Create a source plugin that exposes recipes in the file system Active is failing CI only due to intractable PHPStan problems, I think it makes sense to get this in first, so that we can adjust the baseline before merging that issue.

  • Comment 5 months ago →
    🇦🇺Australia sime Melbourne

    Thanks for the quick RTBC @phenaproxima
    Committer, please credit @mstrelan who kindly sanity checked me.

  • Pipeline finished with Skipped
    5 months ago
    #195765
  • First commit to issue fork.
  • Comment 5 months ago →
    System Message
    • bnjmnm → committed 090a6134 on 1.0.x authored by sime → 
      Issue #3453101 by sime, phenaproxima, mstrelan: phpstan.neon.dist fixes...
  • Status changed to Fixed 5 months ago
  • Comment 5 months ago →
    🇦🇺Australia mstrelan
  • Comment 5 months ago →
    🇺🇸United States bnjmnm Ann Arbor, MI

    Glad to see this spotted and addressed and working up from 1 seems like a good approach.

  • Status changed to Downport 5 months ago
  • Comment 5 months ago →
    🇺🇸United States phenaproxima Massachusetts

    Thanks all! This needs to be ported to 2.0.x also.

  • Comment 5 months ago →
    System Message
    • bnjmnm → committed 42b65494 on 2.0.x authored by sime → 
      Issue #3453101 by sime, phenaproxima, mstrelan: phpstan.neon.dist fixes...
  • Status changed to Fixed 5 months ago
  • Comment 5 months ago →
    🇺🇸United States phenaproxima Massachusetts
  • Comment 5 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024