entityQuery on settings form is missing an access check

Thanks.

It's strange - the report says "and an error will be thrown from drupal:10.0.0." however I just tested on D10 and there was no error. Also everywhere I checked in Core doesn't have the call to accessCheck.

After much head-scratching I believe that the error report is wrong. The link change report states (not obviously, but it's there): "This change doesn't apply to config entities." Which makes sense because they have no access checking. Perhaps you are running an old version of phpstan, or it's a phpstan bug?

Hmm, that is interesting. Yes, in theory these errors should be easy to find because they should result in a WSOD.

It's not a phpstan version problem, as this error can be seen in the GitLab CI report on the project page: https://git.drupalcode.org/project/rrssb/-/jobs/1805469

When I get some time I'll try to dig into how the drupal phpstan extension is doing this analysis; it very well could be a false positive.