- Issue created by @jcnventura
- Merge request !175Issue #3452940: Add GitLab CI to D7, and remove Drupal CI → (Merged) created by jcnventura
- last update
about 1 year ago Build Successful - last update
about 1 year ago run-tests.sh fatal error - Status changed to RTBC
about 1 year ago 11:31am 6 June 2024 - Status changed to Needs work
about 1 year ago 11:57am 6 June 2024 - 🇳🇱Netherlands megachriz
Hm, but it does fail tests. Is that perhaps caused by issues in modules that the D7 version of Feeds depends or integrates with? For example: Job Scheduler, Date, Organic Groups, Feeds XPath Parser...
- 🇵🇹Portugal jcnventura
Yes, most likely this needs at least a composer.json with the correct require-dev, similarly to the D8+ composer.json.
- 🇳🇱Netherlands megachriz
I also see the tests are using PHP 8.1. Would it work better if we use PHP 7.4 on GitLab CI instead? At least for now, so we have better hopes of passing tests. Tests fail on PHP 8 on Drupal CI as well, where the PHP 8.1 failures look related to Job Scheduler.
- 🇳🇱Netherlands megachriz
We could also perhaps disable (or rewrite?) some of the tests. For example, Feeds XPath Parser is an abandoned project, so that one is unlikely to get PHP 8 compatibility. It was replaced by Feeds Extensible Parsers almost a decade ago.
- 🇵🇹Portugal jcnventura
I believe we can force the PHP version in the tests for this to be 7.4. Need to investigate further.
- First commit to issue fork.
- last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - Status changed to Needs review
about 1 year ago 5:13pm 14 June 2024 - 🇨🇦Canada joelpittet Vancouver
Changed the template comments to the current template and read the docs on the test dependencies:
https://project.pages.drupalcode.org/gitlab_templates/info/drupal7/#depe...This is the first one of these I am doing, so we'll see how it goes...
- last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - 🇨🇦Canada joelpittet Vancouver
Getting a bit closer...
I have it set to PHP 7.4 which did help.
MAX PHP: https://git.drupalcode.org/project/feeds/-/jobs/1864063
Not MAX PHP: https://git.drupalcode.org/project/feeds/-/jobs/1864177
PHP 7.4 explicit: https://git.drupalcode.org/project/feeds/-/jobs/1864327I will likely disable some tests if they are from third party integrations failing:
- Organic groups integration 0 passes, 4 fails, and 3 exceptions
- Rules integration 0 passes, 4 fails, and 7 exceptions
I might also create a new release for OG to help here too...
- last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - last update
about 1 year ago run-tests.sh fatal error - Status changed to Fixed
about 1 year ago 7:04am 15 June 2024 -
joelpittet →
committed b2f4d6d3 on 7.x-2.x authored by
jcnventura →
Issue #3452940 by joelpittet, jcnventura, MegaChriz: Add GitLab CI to D7...
-
joelpittet →
committed b2f4d6d3 on 7.x-2.x authored by
jcnventura →
Automatically closed - issue fixed for 2 weeks with no activity.