Resolve Gitlab CI pipeline flagged issues

./src/EventSubscriber/MaintenanceModeRedirectSubscriber.php:21:53 - Unknown word (Subcriber) -- core MaintenanceModeSubcriber events. Suggestions: [Subscriber, Subtribe, Subscribe, Subscribed, Subscribes]

FILE: ...ce_mode_redirect/src/EventSubscriber/MaintenanceModeRedirectSubscriber.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AND 2 WARNINGS AFFECTING 4 LINES -------------------------------------------------------------------------------- 7 | WARNING | [x] Unused use statement | | (Drupal.Classes.UnusedUseStatement.UnusedUse) 14 | WARNING | [ ] The class short comment should describe what the class does | | and not simply repeat the class name | | (Drupal.Commenting.ClassComment.Short) 22 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Arrays.DisallowLongArraySyntax.Found) 33 | ERROR | [x] Short array syntax must be used to define arrays | | (Drupal.Arrays.DisallowLongArraySyntax.Found) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 125ms; Memory: 6MB PHP CODE SNIFFER REPORT SUMMARY -------------------------------------------------------------------------------- FILE ERRORS WARNINGS -------------------------------------------------------------------------------- ...t/src/EventSubscriber/MaintenanceModeRedirectSubscriber.php 2 2 -------------------------------------------------------------------------------- A TOTAL OF 2 ERRORS AND 2 WARNINGS WERE FOUND IN 2 FILES -------------------------------------------------------------------------------- PHPCBF CAN FIX 3 OF THESE SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- PHP CODE SNIFFER VIOLATION SOURCE SUMMARY ---------------------------------------------------------------------- SOURCE COUNT ---------------------------------------------------------------------- [x] Drupal.Arrays.DisallowLongArraySyntax.Found 2 [x] Drupal.Classes.UnusedUseStatement.UnusedUse 1 [ ] Drupal.Commenting.ClassComment.Short 1 ----------------------------------------------------------------------

Line maintenance_mode_redirect.module ------ --------------------------------------------------------------------- 17 Call to static method fromRoute() on an unknown class Url. 💡 Learn more at https://phpstan.org/user-guide/discovering-symbols ------ --------------------------------------------------------------------- ------ ----------------------------------------------------------------------------------------------------------- Line src/EventSubscriber/MaintenanceModeRedirectSubscriber.php ------ ----------------------------------------------------------------------------------------------------------- 32 Parameter $event of method Drupal\maintenance_mode_redirect\EventSubscriber\MaintenanceModeRedirectSubscriber::checkForRedirection() has invalid type Drupal\maintenance_mode_redirect\EventSubscriber\GetResponseEvent. 38 \Drupal calls should be avoided in classes, use dependency injection instead 40 \Drupal calls should be avoided in classes, use dependency injection instead 43 \Drupal calls should be avoided in classes, use dependency injection instead 50 \Drupal calls should be avoided in classes, use dependency injection instead

Comments & Activities

Issue created by @aaron.ferris
Merge request !6Issue #3452766: initial coding standards fixes → (Merged) created by aaron.ferris
Status changed to Needs work 23 days ago4:56pm 5 June 2024
Comment 23 days ago →
🇬🇧United Kingdom aaron.ferris
Comment 23 days ago →
🇬🇧United Kingdom aaron.ferris
Pushed some initial fixes for this, @todo - DI.
Comment 23 days ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Assigned to aaron.ferris
Comment 23 days ago →
🇬🇧United Kingdom aaron.ferris
Status changed to Needs review 22 days ago10:04am 7 June 2024
Comment 22 days ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Comment 21 days ago →
🇬🇧United Kingdom aaron.ferris
Thanks @apaderno, looks good to me. Pulled these changes down and no noticeable issues as far as the functionality is concerned, I think we can merge this in.
Status changed to Fixed 21 days ago12:14pm 8 June 2024
Comment 21 days ago →
🇬🇧United Kingdom aaron.ferris
Comment 21 days ago →
System Message

aaron.ferris → committed 93b08f26 on 2.x
Issue #3452766: initial coding standards fixes
Comment 7 days ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

Resolve Gitlab CI pipeline flagged issues

Merge Requests

!6Resolve Gitlab CI pipeline flagged issues
Merged

Comments & Activities

Resolve Gitlab CI pipeline flagged issues

Merge Requests

!6Resolve Gitlab CI pipeline flagged issuesMerged

Comments & Activities

!6Resolve Gitlab CI pipeline flagged issues
Merged