Contrib.social

Require PHP 8.1 / Drop Drupal 9 support

Open on Drupal.org →
Created on 5 June 2024, 10 months ago
Updated 20 June 2024, 10 months ago

Problem/Motivation

The fix in #3264483: Allow other modules to alter parameters → introduced a readonly constructor promoted property.
PHP 8.1 learned how to do such readonly properties, but previous versions didn't.
Now, while Drupal 10 requires at least PHP 8.1, this module still says it's compatible with Drupal 9, which supported PHP 7.4.
So, technically, this change might break sites once they've updated to a release that includes this change.

Steps to reproduce

Update this module to the latest dev version of 1.x, using Drupal 9 and PHP 7.4.

Proposed resolution

There are many ways that this can be resolved.

  1. We could change the code to not use constructor property promotion.
  2. We could explicitly declare our requirement of PHP 8.1+ in composer.json
  3. We could revert this change on the 1.x branch and introduce a 2.x branch that keeps it, but drops support for Drupal 9.

Remaining tasks

Decide which approach to go for, and then implement it.

User interface changes

None.

API changes

Depends :)

Data model changes

None

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇬🇧United Kingdom steven jones

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024