Form wrapper focus in webformScrollTop not working correctly

Maithri Shetty → made their first commit to this issue’s fork.

@mstrelan I have raised a PR for requested change. Can you please provide me the steps to reproduce the issue so that I can cross verify in my local as well. Thank you.

1. Install Drupal standard profile
2. Install Webform and Webform UI module
3. Edit the default Contact webform and enabled AJAX
4. Go to /form/contact and hit submit to trigger a validation error
5. Inspect the page markup and notice an empty span above the webform, rather than wrapping the webform

@mstrelan cross verified and works fine. Thank you

Hello,

Thanks for filing this issue.

However, I suggest solving it in another way, as using a span to wrap a div and a whole form is invalid according to W3C HTML standards.

My suggestion would be :

• in JS : remove '-content' from the selector, so it targets the initial wrapper div which effectively contains the form
• in PHP : keep span where it is, but add tabindex="-1" so it can effectively get the focus (currently it can't, whether wrapping the form or not)

I will try to commit this changes next week.

Please rebase against 6.3.x.

@lkmorlan Thank you ! It should be OK now, I could apply the patch from the MR locally.

jrockowitz → changed the visibility of the branch 3452360-form-wrapper-focus-scroll to hidden.

We can't have a DIV wrapper with a SPAN but we can convert the SPAN to a DIV and then wrap the form,

@jrockowitz Thanks for the changes.
It seems OK for me regarding the structure, but it still misses tabindex="-1" to effectively get the focus (as a div is not focusable by default).

Done!