7.x - Fix coding standards issues

Created on 1 June 2024, 11 months ago
Updated 9 August 2024, 9 months ago

Once the pipeline is enabled, check for failures, phpcs etc.

📌 Task
Status

Needs review

Component

Code

Created by

🇬🇧United Kingdom aaron.ferris

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @aaron.ferris
  • Merge request !8Issue #3451780: add project words → (Closed) created by aaron.ferris
  • 🇬🇧United Kingdom aaron.ferris
    FILE: .../aaron/Work/drupal-contrib/menu_css_names/menu_css_names.install
    ----------------------------------------------------------------------
    FOUND 4 ERRORS AND 3 WARNINGS AFFECTING 7 LINES
    ----------------------------------------------------------------------
      4 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
      5 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
      6 | ERROR   | [x] Expected 1 space(s) before asterisk; 0 found
      9 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
        |         |     Implements hook_foo_BAR_ID_bar() for
        |         |     xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
        |         |     for xyz-bar.html.twig.", "* Implements
        |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
        |         |     "* Implements hook_foo_BAR_ID_bar() for block
        |         |     templates."
     16 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
        |         |     Implements hook_foo_BAR_ID_bar() for
        |         |     xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
        |         |     for xyz-bar.html.twig.", "* Implements
        |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
        |         |     "* Implements hook_foo_BAR_ID_bar() for block
        |         |     templates."
     23 | WARNING | [ ] Format should be "* Implements hook_foo().", "*
        |         |     Implements hook_foo_BAR_ID_bar() for
        |         |     xyz_bar().",, "* Implements hook_foo_BAR_ID_bar()
        |         |     for xyz-bar.html.twig.", "* Implements
        |         |     hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or
        |         |     "* Implements hook_foo_BAR_ID_bar() for block
        |         |     templates."
     27 | ERROR   | [x] Expected 1 newline at end of file; 0 found
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------
    FILE: ...s/aaron/Work/drupal-contrib/menu_css_names/menu_css_names.module
    ----------------------------------------------------------------------
    FOUND 121 ERRORS AND 11 WARNINGS AFFECTING 79 LINES
    ----------------------------------------------------------------------
      13 | ERROR   | [x] Doc comment short description must end with a
         |         |     full stop
      13 | ERROR   | [x] Whitespace found at end of line
      19 | ERROR   | [x] Whitespace found at end of line
      23 | ERROR   | [x] Whitespace found at end of line
      27 | ERROR   | [x] Whitespace found at end of line
      31 | ERROR   | [x] Whitespace found at end of line
      35 | ERROR   | [x] Expected 1 blank line after function; 2 found
      41 | ERROR   | [x] Whitespace found at end of line
      42 | ERROR   | [ ] Doc comment short description must be on a
         |         |     single line, further text should be a separate
         |         |     paragraph
      43 | ERROR   | [x] There must be no blank lines after the function
         |         |     comment
      63 | ERROR   | [x] Whitespace found at end of line
      81 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      81 | ERROR   | [x] Whitespace found at end of line
      82 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      82 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
         |         |     found 3
      82 | ERROR   | [x] Inline comments must start with a capital letter
      83 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      83 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
         |         |     found 4
      84 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      84 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
         |         |     found 4
      85 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      85 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
         |         |     found 4
      86 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      86 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
         |         |     found 4
      87 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      87 | ERROR   | [x] Line indented incorrectly; expected 8 spaces,
         |         |     found 6
      88 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      88 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
         |         |     found 3
      88 | ERROR   | [x] Closing brace indented incorrectly; expected 4
         |         |     spaces, found 3
      89 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      89 | WARNING | [x] There must be no blank line following an inline
         |         |     comment
      89 | WARNING | [ ] There must be no blank line following an inline
         |         |     comment
      89 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
         |         |     found 3
      89 | ERROR   | [x] Inline comments must start with a capital letter
      89 | ERROR   | [x] Inline comments must end in full-stops,
         |         |     exclamation marks, question marks, colons, or
         |         |     closing parentheses
      90 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
      90 | ERROR   | [x] Whitespace found at end of line
      91 | WARNING | [ ] Line exceeds 80 characters; contains 85
         |         |     characters
     109 | WARNING | [ ] Line exceeds 80 characters; contains 112
         |         |     characters
     128 | ERROR   | [x] Expected 1 blank line after function; 2 found
     132 | ERROR   | [x] Doc comment short description must end with a
         |         |     full stop
     134 | ERROR   | [ ] Wrong function doc comment end; expected "*/",
         |         |     found "**/"
     134 | ERROR   | [x] Additional blank lines found at end of doc
         |         |     comment
     142 | ERROR   | [x] Whitespace found at end of line
     143 | ERROR   | [x] Inline comments must start with a capital letter
     149 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     149 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     149 | ERROR   | [x] Closing brace indented incorrectly; expected 2
         |         |     spaces, found 1
     150 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     150 | WARNING | [x] There must be no blank line following an inline
         |         |     comment
     150 | WARNING | [ ] There must be no blank line following an inline
         |         |     comment
     150 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     150 | ERROR   | [x] Inline comments must start with a capital letter
     150 | ERROR   | [x] Inline comments must end in full-stops,
         |         |     exclamation marks, question marks, colons, or
         |         |     closing parentheses
     151 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     151 | ERROR   | [x] Whitespace found at end of line
     154 | ERROR   | [x] Expected 1 blank line after function; 2 found
     176 | ERROR   | [x] Doc comment short description must end with a
         |         |     full stop
     178 | ERROR   | [ ] Wrong function doc comment end; expected "*/",
         |         |     found "**/"
     178 | ERROR   | [x] Additional blank lines found at end of doc
         |         |     comment
     193 | ERROR   | [ ] The array declaration extends to column 113 (the
         |         |     limit is 80). The array content should be split
         |         |     up over multiple lines
     195 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     195 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     195 | ERROR   | [x] Inline comments must start with a capital letter
     195 | ERROR   | [x] Inline comments must end in full-stops,
         |         |     exclamation marks, question marks, colons, or
         |         |     closing parentheses
     197 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     197 | ERROR   | [x] Whitespace found at end of line
     199 | ERROR   | [x] Inline comments must start with a capital letter
     199 | ERROR   | [x] Inline comments must end in full-stops,
         |         |     exclamation marks, question marks, colons, or
         |         |     closing parentheses
     200 | ERROR   | [x] Expected 1 blank line after function; 2 found
     206 | ERROR   | [ ] Missing parameter type
     208 | ERROR   | [ ] Missing parameter type
     211 | ERROR   | [ ] Missing parameter type
     240 | ERROR   | [ ] The array declaration extends to column 90 (the
         |         |     limit is 80). The array content should be split
         |         |     up over multiple lines
     244 | ERROR   | [x] Whitespace found at end of line
     245 | ERROR   | [x] Inline comments must start with a capital letter
     245 | ERROR   | [x] Inline comments must end in full-stops,
         |         |     exclamation marks, question marks, colons, or
         |         |     closing parentheses
     247 | WARNING | [x] There must be no blank line following an inline
         |         |     comment
     247 | WARNING | [ ] There must be no blank line following an inline
         |         |     comment
     247 | ERROR   | [x] Inline comments must start with a capital letter
     247 | ERROR   | [x] Inline comments must end in full-stops,
         |         |     exclamation marks, question marks, colons, or
         |         |     closing parentheses
     248 | ERROR   | [x] Whitespace found at end of line
     255 | ERROR   | [ ] The array declaration extends to column 120 (the
         |         |     limit is 80). The array content should be split
         |         |     up over multiple lines
     258 | ERROR   | [x] Whitespace found at end of line
     259 | ERROR   | [x] Line indented incorrectly; expected 8 spaces,
         |         |     found 9
     260 | ERROR   | [x] Array indentation error, expected 11 spaces but
         |         |     found 10
     261 | ERROR   | [x] Array indentation error, expected 11 spaces but
         |         |     found 10
     262 | ERROR   | [x] Array indentation error, expected 11 spaces but
         |         |     found 10
     262 | ERROR   | [x] Expected 1 space after "=>"; 2 found
     263 | ERROR   | [x] Array indentation error, expected 11 spaces but
         |         |     found 10
     264 | ERROR   | [x] Array indentation error, expected 11 spaces but
         |         |     found 10
     265 | ERROR   | [x] Array closing indentation error, expected 9
         |         |     spaces but found 8
     267 | ERROR   | [x] Whitespace found at end of line
     268 | ERROR   | [x] Concat operator must be surrounded by a single
         |         |     space
     281 | ERROR   | [x] Whitespace found at end of line
     285 | ERROR   | [x] Expected 1 space after "=>"; 2 found
     297 | WARNING | [ ] Line exceeds 80 characters; contains 83
         |         |     characters
     297 | ERROR   | [x] Inline comments must start with a capital letter
     298 | WARNING | [ ] Line exceeds 80 characters; contains 82
         |         |     characters
     299 | ERROR   | [x] Inline comments must end in full-stops,
         |         |     exclamation marks, question marks, colons, or
         |         |     closing parentheses
     300 | ERROR   | [x] You must use "/**" style comments for a function
         |         |     comment
     301 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     301 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     302 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     302 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
         |         |     found 3
     303 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     303 | ERROR   | [x] Line indented incorrectly; expected 6 spaces,
         |         |     found 3
     304 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     304 | ERROR   | [x] Line indented incorrectly; expected 4 spaces,
         |         |     found 2
     304 | ERROR   | [x] Closing brace indented incorrectly; expected 3
         |         |     spaces, found 2
     305 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     305 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     306 | ERROR   | [x] Expected 1 blank line after function; 2 found
     309 | ERROR   | [x] Inline comments must start with a capital letter
     310 | WARNING | [ ] Line exceeds 80 characters; contains 85
         |         |     characters
     312 | ERROR   | [ ] All functions defined in a module file must be
         |         |     prefixed with the module's name, found
         |         |     "_make_class_name" but expected
         |         |     "menu_css_names__make_class_name"
     312 | ERROR   | [x] You must use "/**" style comments for a function
         |         |     comment
     313 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     313 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     313 | ERROR   | [x] Inline comments must start with a capital letter
     314 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     314 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     314 | ERROR   | [x] Inline comments must end in full-stops,
         |         |     exclamation marks, question marks, colons, or
         |         |     closing parentheses
     315 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     315 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     316 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     316 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     317 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     317 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     318 | ERROR   | [x] Spaces must be used to indent lines; tabs are
         |         |     not allowed
     318 | ERROR   | [x] Line indented incorrectly; expected 2 spaces,
         |         |     found 1
     319 | ERROR   | [x] Expected 1 newline at end of file; 0 found
    ----------------------------------------------------------------------
    PHPCBF CAN FIX THE 114 MARKED SNIFF VIOLATIONS AUTOMATICALLY
    ----------------------------------------------------------------------
  • 🇬🇧United Kingdom aaron.ferris

    Ive pushed a change for the .install, we still need the .module.

  • Merge request !9Issue #3451780: coding standards → (Open) created by aaron.ferris
  • 🇬🇧United Kingdom aaron.ferris

    aaron.ferris changed the visibility of the branch 2.0.x to hidden.

  • 🇬🇧United Kingdom aaron.ferris

    aaron.ferris changed the visibility of the branch 7.x-1.x to hidden.

  • 🇬🇧United Kingdom aaron.ferris

    aaron.ferris changed the visibility of the branch 3451780-coding-standards to hidden.

  • Merge request !10Resolve #3451780 "Coding standards mk2" → (Merged) created by aaron.ferris
  • 🇬🇧United Kingdom nexusnovaz

    NexusNovaz changed the visibility of the branch 3451780-coding-standards-mk2 to hidden.

  • 🇬🇧United Kingdom nexusnovaz

    NexusNovaz changed the visibility of the branch 3451780-coding-standards-mk2 to active.

  • Merge request !25Resolve #3451780 "Coding standards mk2" → (Open) created by aaron.ferris
  • Status changed to Needs review 9 months ago
Production build 0.71.5 2024