- Issue created by @jonathan1055
- ๐ฌ๐งUnited Kingdom jonathan1055
As a baseline, the current CSPELL job shows
CSpell: Files checked: 78, Issues found: 4688 in 37 files The number of unrecognised/misspelled words is 4369
The log is 8,800 lines long.
- last update
6 months ago 26 pass - ๐ฌ๐งUnited Kingdom jonathan1055
Big improvement on first run, using
_CSPELL_IGNORE_PATHS: 'doc/drupal_org_documentation/Geofield_Mapping_in_Drupal.key'
https://git.drupalcode.org/issue/geofield-3451574/-/jobs/1739903CSpell: Files checked: 77, Issues found: 262 in 36 files The number of unrecognised/misspelled words is 53
4369 words reduced to 53
- last update
6 months ago 26 pass - ๐ฌ๐งUnited Kingdom jonathan1055
I added a
.cspell-project-words.txt
file to contain the specific partially-invented words that are not know by cspell. This further reduced the word count from 53 down to 29CSpell: Files checked: 77, Issues found: 120 in 31 files The number of unrecognised/misspelled words is 29
- last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - ๐ฌ๐งUnited Kingdom jonathan1055
Corrected some more words, and added a few into the project dictionary. Not many left now:
CSpell: Files checked: 77, Issues found: 20 in 9 files The number of unrecognised/misspelled words is 9
- last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - last update
6 months ago 26 pass - Issue was unassigned.
- Status changed to Needs review
6 months ago 4:49pm 31 May 2024 - ๐ฌ๐งUnited Kingdom jonathan1055
The CSPELL job now passes and ends green.
Spell: Files checked: 76, Issues found: 0 in 0 files
https://git.drupalcode.org/issue/geofield-3451574/-/jobs/1742027MR32 is ready for review
- First commit to issue fork.
- last update
5 months ago 26 pass - Status changed to RTBC
5 months ago 5:03pm 4 June 2024 - ๐ฎ๐ณIndia ankitv18
I moved those words into .txt file as few of them are repeated so it would be best to move those words into right place.
Marking this RTBC as CSPELL pipeline is passing now and changes done in the MR!32 is related to the CSPELL only. - ๐ฌ๐งUnited Kingdom jonathan1055
Hi @anktiv18,
Your changes are OK to add the testing words into the dictionary, but I suggest we do not want the maintainers in it. I think it was better how I did it forst, when that section of the readme file was ignored with a one-line comment. The dictionary does not need to be filled with personal names. But I guess that is up to the maintainers choice. - ๐ฎ๐ณIndia ankitv18
@jonathan1055,
Either way I'm fine to get this one merged, if @itamir asked to put cspell ignore in the readme to ignore maintainer names then I'll revert the change for readme.md - last update
5 months ago 26 pass - last update
5 months ago 26 pass - last update
5 months ago 26 pass - First commit to issue fork.
- last update
5 months ago 26 pass - last update
5 months ago 26 pass -
itamair โ
committed e3a9c14a on 8.x-1.x authored by
jonathan1055 โ
Issue #3451574 by jonathan1055, ankitv18, itamair: Fix spelling in...
-
itamair โ
committed e3a9c14a on 8.x-1.x authored by
jonathan1055 โ
- Status changed to Fixed
5 months ago 9:42am 18 June 2024 - ๐ฌ๐งUnited Kingdom jonathan1055
You have deleted two files, so this is more than just "fix spelling". I think that needs to be commented somewhere here.
Also I don't know why you added the readme.md to the ignore_paths, when I provided a simple way to ignore the block of maintainers names but still check spelling in the rest of the file. If any file needs to have correct spelling it is the one file which we want people to read, the readme.md :-)
- ๐ฎ๐นItaly itamair
Donโt worry @jonathan1055
Itโs all good here.
Letโs not make any drama of this simple task.
The 2 removed files were just un-used assets files, and you already mentioned them, so we are all good.
Lol โฆ and letโs enjoy life ๐ Automatically closed - issue fixed for 2 weeks with no activity.