Fix phpstan errors

Created on 28 May 2024, 7 months ago

Problem/Motivation

$ php vendor/bin/phpstan analyze $_WEB_ROOT/modules/custom/$CI_PROJECT_NAME $PHPSTAN_CONFIGURATION --no-progress || EXIT_CODE=$?
 ------ ---------------------------------------------------------------------- 
  Line   src/Form/Settings.php                                                 
 ------ ---------------------------------------------------------------------- 
  110    \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 [ERROR] Found 1 error                                                          
$ echo "Generating an PHPStan baseline file (available as job artifact) that can be included in the project. If the project already has one, you might need to manually merge them." # collapsed multi-line command
Generating an PHPStan baseline file (available as job artifact) that can be included in the project. If the project already has one, you might need to manually merge them.
 [OK] Baseline generated with 1 error.                                          
$ sed -i "s#$_WEB_ROOT/modules/custom/$CI_PROJECT_NAME/##" junit.xml phpstan-baseline.neon phpstan-quality-report.json || true
$ exit $EXIT_CODE
Uploading artifacts for failed job
00:02
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories 
phpstan-baseline.neon: found 1 matching artifact files and directories 
phpstan-quality-report.json: found 1 matching artifact files and directories 
Uploading artifacts as "archive" to coordinator... 201 Created  id=1710202 responseStatus=201 Created token=glcbt-64
Uploading artifacts...
junit.xml: found 1 matching artifact files and directories 
Uploading artifacts as "junit" to coordinator... 201 Created  id=1710202 responseStatus=201 Created token=glcbt-64
Uploading artifacts...
phpstan-quality-report.json: found 1 matching artifact files and directories 
Uploading artifacts as "codequality" to coordinator... 201 Created  id=1710202 responseStatus=201 Created token=glcbt-64
Cleaning up project directory and file based variables
00:01
ERROR: Job failed: command terminated with exit code 1
📌 Task
Status

Fixed

Component

Code

Created by

🇪🇸Spain gxleano Cáceres

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024