Contrib.social

Fix CSS and JS assets with SingleDirectoryObjectListTrait

Open on Drupal.org →
Created on 28 May 2024, 8 months ago
Updated 14 June 2024, 7 months ago

Problem/Motivation

Not sure if it ever worked, SingleDirectoryObjectListTrait is using @namespace notation for js and css assets, which \Drupal\Core\Asset\LibraryDiscoveryParser doesnt recognise. We should use relative to DRUPAL_ROOT.

Theres not much other options in the parser, other than either:

By default, file paths are relative to the registering extension.

An absolute path maps to DRUPAL_ROOT / base_path().

Perhaps this was changed since it didnt work on CI?

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

🇦🇺Australia dpi Perth, Australia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024