- Issue created by @alex.bukach
- 🇮🇱Israel jsacksick
hm... I'm not sure why you're bringing up Commerce API here? Could you be a little bit more specific? Are you manipulating the same order via the API and via the regular fullstack checkout at the same time?
- Issue was unassigned.
- Status changed to Needs review
12 months ago 12:08pm 28 May 2024 - 🇨🇾Cyprus alex.bukach
@jsacksick, Commerce API is a dependency of Commerce Cart Flyout → .
- last update
12 months ago 160 pass - 🇮🇱Israel jsacksick
@jsacksick, Commerce API is a dependency of Commerce Cart Flyout.
No, Commerce Cart API is, not Commerce API.
Also, your fix would set a precedent, if we start doing that here, we'd need similar "hacks"/workarounds in pretty much all other checkout panes... Except yeah, this one might be the only one saving the order at this stage.
- 🇨🇾Cyprus alex.bukach
Sorry, my fault @jsacksick, I have updated the issue description.
I understand it might be not the best solution, however it's ShippingInformation pane that saves a shipping profile and then almost immediately saves a related order which in the case contains the shipping profile as well (though stale), and I cannot see any other way to hook into the process.
The same solution was suggested in the " OrderVersionMismatchException caused by ShippingInformation.php unnecessarily saving the order → ", however there were able to find more elegant solution. Can you see another way to fix it in the case?
- 🇨🇾Cyprus alex.bukach
@jsacksick sorry again, it is Commerce API that provides the base field, we do use it as well, and I am checking whether we still need it :)
- Status changed to Closed: works as designed
11 months ago 5:06pm 1 June 2024 - 🇨🇾Cyprus alex.bukach
@jsacksick, at currently our project uses only fields declared Commerce API's, so we can rework the code to uninstall it. However I believe Commerce API should not break commerce shipping functionality anyway. I have found other scenarios when shipping address is empty, and the attached patch does not fix them. Therefore I dig further and came to another solution I posted in an issue for Commerce API 🐛 Empty shipping address Needs review . Therefore I am closing this issue.