- Issue created by @dinarcon
- Status changed to Needs review
11 months ago 5:14pm 27 May 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Gábor Hojtsy → made their first commit to this issue’s fork.
- Status changed to Needs work
11 months ago 5:54pm 27 May 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Good find! One line fix makes total sense.
MR had merge conflicts :/ I tried to create another branch to make this easier but that does not want to update from the original repo either without local merge resolution. Strange. Can you help with resolving that or should I directly commit to 7.2.x (with proper attribution of course)?
- 🇳🇮Nicaragua dinarcon
dinarcon → changed the visibility of the branch 3450182-projects-moved-into to hidden.
- 🇳🇮Nicaragua dinarcon
dinarcon → changed the visibility of the branch 3450182-projects-moved-into to active.
- Status changed to Needs review
11 months ago 7:53pm 27 May 2024 - 🇳🇮Nicaragua dinarcon
Thanks for the quick reply. Committing directly commit to 7.2.x is fine. I am not sure what happened with the issue fork. When I created my PR it was against the
7.x-2.x
branch. I am surprised that it had a merge conflict because my commit changed only one line compared to HEAD. The MR now says that it is against 4.x with a lot more changes. I don't really understand what happened there.BTW, sorry for changing the visibility of the `3450182-projects-moved-into` branch. I was trying to review things and clicked the wrong link. I changed it back to visible.
-
Gábor Hojtsy →
committed c9e68e6c on 7.x-2.x
Issue #3450182 by dinarcon: Projects moved into Core not reported when...
-
Gábor Hojtsy →
committed c9e68e6c on 7.x-2.x
- Status changed to Fixed
11 months ago 7:01am 28 May 2024 - 🇭🇺Hungary Gábor Hojtsy Hungary
Duh probably I created the MR wrong then. Either way, committed that one line directly, that was easiest, instead of trying to fix the MR. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.