- Issue created by @keebOo
- π¬π§United Kingdom aaron.ferris
aaron.ferris β made their first commit to this issueβs fork.
- Status changed to Needs review
6 months ago 4:00pm 27 May 2024 - π§π·Brazil mabho Rio de Janeiro, RJ
Thank you, guys, for the review, your comment makes sense. I am not sure this is my preferred approach, but I will accept the answer/contribution for now, and I can wrap my mind around this topic again in the future.
-
mabho β
committed a5e1a189 on 1.0.x authored by
aaron.ferris β
Issue #3450161 by aaron.ferris, keebOo, mabho: "Deactivate debugger"...
-
mabho β
committed a5e1a189 on 1.0.x authored by
aaron.ferris β
- π§π·Brazil mabho Rio de Janeiro, RJ
Thank you keebOo for raising this queue, thank you Aaron Ferris for providing the code.
- πΈπ¬Singapore anish.a Singapore
Tested in 1.0.x-dev and is working fine. See the screenshots.
However, the "Activate debugger" part is not visible at all. May be not provide it?
- π¬π§United Kingdom aaron.ferris
The activate debugger label wasn't visible previously, only the eye icon so this is as it was previously, unless im missing something.
- π§π·Brazil mabho Rio de Janeiro, RJ
Thank you for running the tests, Anish. The idea is the user only needs a visual cue to activate the console, there is probably no need for a label there. It is probably better to be minimalist. After one or two interactions, it will be clear for the user how to activate/deactivate the debugger (in case it wasn't in the first place).
Maybe a label is not even required when the console is open (the eye icon is possibly self-explanatory). I think I will ask the opinions of some fellow designers and we can probably improve this interface. For the time being, I think this fix is good enough, I really appreciate your help, and Aaron's.
- Status changed to RTBC
6 months ago 12:08pm 28 May 2024 - πΈπ¬Singapore anish.a Singapore
Since this is already merged, should we move to fixed?
- Status changed to Fixed
6 months ago 2:34am 29 May 2024 - Status changed to Fixed
6 months ago 3:02am 29 May 2024