- Issue created by @nightlife2008
- Assigned to sourav_paul
- Merge request !13Issue #3450024 by Sourav_Paul: Personalization typo → (Merged) created by sourav_paul
- Status changed to Needs review
7 months ago 8:30pm 27 May 2024 - 🇧🇪Belgium andreasderijcke Antwerpen / Gent
If anyone can add the update hook, this can be released faster. I might not get to it before wednesday.
- Issue was unassigned.
- 🇮🇳India sourav_paul Kolkata
I've created a MR for this one..
@Maintainers pls review this.
- 🇧🇪Belgium andreasderijcke Antwerpen / Gent
@Sourav_Paul Are you able to add update hook too, for potential installs that already have config on the wrong config key?
- Assigned to sourav_paul
- Status changed to Needs work
7 months ago 11:47am 30 May 2024 - Issue was unassigned.
- Status changed to Needs review
7 months ago 12:07pm 30 May 2024 - 🇮🇳India sourav_paul Kolkata
@andreasderijcke I've added update, Could please merge it?
- Assigned to andreasderijcke
-
andreasderijcke →
committed 17c3265f on 1.0.x authored by
Sourav_Paul →
Issue #3450024: Personalization typo
-
andreasderijcke →
committed 17c3265f on 1.0.x authored by
Sourav_Paul →
- 🇧🇪Belgium andreasderijcke Antwerpen / Gent
@Sourav_Paul Some feedback:
- I'm not sure how, but you have seemed to have overwritten the first commit on the merge request with the second. Following the git commands here on on the MR itself, it should be no problem to add commits to an existing MR. Something to double check in the future.
- About the update hook, 2 aspects:
- The convention is to keep update hooks in the .install file, not .module and follow the existing update hook numbering unless to indicate major version jumps, which is not the case here.
So the last one was 10001, so this one becomes 10002 and not 11001. - Update hook code itself was good, just didn't take possible language override into account.
- The convention is to keep update hooks in the .install file, not .module and follow the existing update hook numbering unless to indicate major version jumps, which is not the case here.
In anyway, thanks for helping out.
@nightlife2008, thanks for reporting and patch.
- Issue was unassigned.
- Status changed to Fixed
7 months ago 2:01pm 4 June 2024 - 🇮🇳India sourav_paul Kolkata
Thanks @andreasderijcke for your feedback, I'll keep this in mind for future.
Automatically closed - issue fixed for 2 weeks with no activity.