- Issue created by @stBorchert
- Status changed to Needs review
3 months ago 6:47am 27 May 2024 - 🇩🇪Germany stBorchert
I've added a test to Drupal\KernelTests\Core\Database\InsertTest and Drupal\KernelTests\Core\Database\UpsertTest and a small change to
Upsert::preExecute()
.
Without the change, the test method in UpsertTest will fail. - Merge request !8199Issue #3439909 by SolimanHarkas, vensires: Fix Taxonomy tests that rely on... → (Open) created by smustgrave
- Status changed to Needs work
3 months ago 2:38pm 27 May 2024 - 🇺🇸United States smustgrave
Opened up an MR based on the branch that was present but got a ton of changes.
- 🇩🇪Germany stBorchert
Hm, maybe it's because I've branched from 11.x and not 11.0.x?
- 🇩🇪Germany stBorchert
I've added a new branch and pushed my changes to it.
@smustgrave Could you please create a new MR for it? I don't seem to be able to do this (https://git.drupalcode.org/issue/drupal-3449991/-/merge_requests/new results in a 404). - 🇺🇸United States smustgrave
Sure will take a look. But the existing MR may just need a rebase
- First commit to issue fork.
- Status changed to Needs review
3 months ago 8:11am 28 May 2024 - Status changed to Needs work
3 months ago 12:58pm 28 May 2024 - 🇩🇪Germany stBorchert
Hm, I don't see how this is related to the changes in the MR ... https://git.drupalcode.org/issue/drupal-3449991/-/jobs/1705056#L5182