- Issue created by @cmlara
- πΊπΈUnited States cmlara
As a test dependency we need to wait on Key:
π [META] Key for Drupal 11 Active - πΊπΈUnited States cmlara
D10.3 has landed.
I had forgotten in the past Key could run a bit behind, we may want to debate reverting π Key module should be a Dev Dependency. Fixed since none of the tests depend upon it and it is only phpstan reporting. 4.x will need key, we might want to get use to the slight delay.
We can start working on the Automated D11 issue import, though the vast majority of it is not useable (it detects our D9/D8 BC layers and attempts to use D10 only features.
- Status changed to Active
9 months ago 6:30pm 27 June 2024 - πΊπΈUnited States japerry KVUO
Key supports Drupal 11 now, setting back to active.
- Assigned to cmlara
- πΊπΈUnited States cmlara
Dealing with a PHPStan warning that only shows up on D11.
Call to method confirm() on an unknown class Drush\Style\DrushStyle
Have a query into #drush and #phpstan.https://git.drupalcode.org/issue/s3fs-3449990/-/pipelines/215377 is the latest pipeline with D11.
Lack of code coverage driver is causing a PHPUnit warning leading to a step failure. PHPUnit is otherwise passing.
Will open a separate issue to restore code coverage. - Status changed to Needs review
8 months ago 7:16am 4 July 2024 - πΊπΈUnited States cmlara
With assistance from @jurgenhass on Slack I was reminded of the normal solution for dealing with symbols that are not found however exist on disk.
Added fix into code and latest D11 run shows the Drush related validation is no longer present. https://git.drupalcode.org/issue/s3fs-3449990/-/pipelines/215416
I'm not going to hold this up on the PHPUnit(Code coverage) failure as this code can cleanly commits and runs under D10 and the tests otherwise pass in D11.
Setting to Needs Review for community comment (and to allow me time to step away and return to re-evaluate any possible improvements in the code as currently written).
- Status changed to Fixed
8 months ago 5:43am 1 August 2024 -
cmlara β
committed 91371741 on 8.x-3.x
Issue #3449990 by cmlara: Add D11.0 support
-
cmlara β
committed 91371741 on 8.x-3.x
Automatically closed - issue fixed for 2 weeks with no activity.