- Issue created by @mandclu
- last update
6 months ago Composer require failure - Assigned to zengenuity
- 🇨🇦Canada mandclu
@zengenuity I believe the code changes proposed here should make this module compatible with Drupal 11, although requiring at least Drupal 10.1 in the process. Please review and confirm that everything still works as expected.
- Status changed to Needs review
6 months ago 7:16pm 24 May 2024 - First commit to issue fork.
- Status changed to Needs work
6 months ago 1:50pm 27 May 2024 - 🇺🇸United States zengenuity
@mandclu, this looks good except the switch from fnmatch() to glob(). That code crashes when I test it.
I also made a few additional changes to the handling of dependencies in easy_email_commerce to make sure we don't crash from missing modules there.
- Status changed to Needs review
6 months ago 1:14pm 5 June 2024 - 🇨🇦Canada mandclu
I decided to revert the places where I had directly accessed the entityTypeManager as a property instead of using the accessor method, since it was effectively bypassing an API. I've also tried a different method to replace fnmatch(), hopefully this one works better.
-
zengenuity →
committed c0cb9f6d on 3.0.x authored by
mandclu →
Issue #3449593 by mandclu: Drupal 11 compatibility
-
zengenuity →
committed c0cb9f6d on 3.0.x authored by
mandclu →
- Status changed to Fixed
4 months ago 5:49pm 12 July 2024 - 🇺🇸United States zengenuity
This all looks good now. I tested it manually on D10 and D11, and it worked in both places.
I've merged the MR and created a new release: 3.0.1. Thanks for your work on this!
Today, I also released a new version of Drupal Symfony Mailer Lite → that is D11-compatible. So, we have a full D11 solution for emails on day 1. (currently using dev branches for Mail System and Token, which are D11 compatible)
Automatically closed - issue fixed for 2 weeks with no activity.