- Issue created by @jonnyhocks
- Status changed to Needs review
11 months ago 10:45am 24 May 2024 - 🇬🇧United Kingdom jonnyhocks
Here's a patch which updates the namespaces from the scheduler module.
- Status changed to Needs work
11 months ago 3:03pm 29 May 2024 - 🇬🇧United Kingdom nicrodgers Monmouthshire, UK
Thanks for the patch.
Is it possible to do that patch so that it works with both versions of scheduler?
If the patch fixes it with the latest version of scheduler, presumably it will break for people still using the previous version?
So to avoid releasing a new major version of advanced_scheduler I was wondering whether it was possible to make it work with both.If not, we can roll this in to a new major version.
- 🇨🇦Canada metasim
Namespace declaration for
"Drupal\scheduler\Event\SchedulerEvent"
to
"Drupal\scheduler\Event\SchedulerNodeEvents"So updating the patch with the same
@nicrodgers I am not sure how to create a patch that would be valid for both the 2.1 and 2.2 version of the scheduler module, If someone can share steps on how to achieve that, I can update the current patch accordingly
- First commit to issue fork.
- Merge request !3Issue #3449583 by metasim, codebymikey, nicrodgers: Improve support for scheduler 1.x and 2.x → (Open) created by codebymikey
- Merge request !4Issue #3449583 by codebymikey, metasim: Drop support for scheduler 1.x → (Open) created by codebymikey
Provided patches and MR for two approaches.
1. Dropping support for 1.x.
2. Adding support for both versions.The implementation route is down to discretion of the maintainer.