- Issue created by @roderik
- First commit to issue fork.
- Assigned to junkuncz
- Status changed to Needs work
4 months ago 2:31pm 18 August 2024 - Merge request !82Wrong default element name for new non-default CE display → (Closed) created by junkuncz
- Issue was unassigned.
- Status changed to Needs review
4 months ago 7:24am 19 August 2024 - Status changed to Needs work
4 months ago 7:52am 19 August 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Then test.
Testing isn't hard. Once you test and see no strange behavior / warnings, I can merge it without looking at it further (just in this specific issue's case).
- 🇦🇹Austria fago Vienna
I worked on this and actually have seen it working, or fixed on the go. let's re-test this after 🐛 drupal prefix is added to configured custom element names Active please + let's mark it fixed if so then.
- 🇭🇺Hungary junkuncz Budapest
@fago you are right. I've just rebased and all looks good (see attachments) cc.: @roderik
- Status changed to RTBC
4 months ago 7:52am 21 August 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Yes.
This whole (hastily created) issue's premise was wrong. Because
$this->originalMode
is not the 'original view mode of the config object. It is the 'originally requested view mode'. (Naming is bleh.)So
$this->originalMode
is actually what we want here / the proposed fix is bogus.Instead, @fago's recently added createCopy() fixes things. Today I learned-or-relearned about createCopy() / what happens when a non-default view mode is activated through the UI.
Thanks for testing.
- Status changed to Fixed
4 months ago 1:16pm 23 August 2024 Automatically closed - issue fixed for 2 weeks with no activity.