- Issue created by @roderik
- 🇦🇹Austria fago Vienna
as I understand the problem is the configuration is not applied 1:1 as expected. yeah, we should allow setting some explicit '' prefix and simply do so when generating the element from config
- 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
See spec in 📌 Consistently prefix components with drupal- Active
- 🇦🇹Austria fago Vienna
re-titling to implement the spec mentioned by roderik - this includes removing the drupal prefix for entities.
Here the relevant spec
* For rendering content entities, we do not add a drupal- prefix. We apply the following pattern: `{ENTITY_TYPE}-{BUNDLE}-{VIEW_MODE}` or when the entity does not use bundles `{ENTITY_TYPE}-{VIEW_MODE}`. The view-mode suffix should be optional.
* Also, for the default view-mode we do not append the "-default" suffix, since e.g. "node-article[...].vue" clearly is already default, there is no "node-article-default" element needed. - Merge request !84Issue #3449151 by fago: Improve default CE-naming pattern for content entities. → (Merged) created by fago
- Status changed to Needs review
3 months ago 6:35am 20 August 2024 - 🇦🇹Austria fago Vienna
create the MR with the necessary changes. Short summary:
* The default names are updated according the described pattern
* Thunder module default config has been updated to follow it. Strictly speaking some BC-break, but well we do general new CE-UI names in 3.x so this just part of it. We should not be afraid to change it. When necessary it can be re-configured to old values anyway. (any drunomics-internal necessary changes due to can be done later)
* I ran into some fatal error due to hidden being ended up "null" in some config when editing displays due to some parent code in the parent class. We should keep it an empty array instead of making it null to avoid troubles there.
* Tests have been updated to follow the changes and use the new names. There is one change in the functional test markup though. will comment there. - Status changed to Fixed
3 months ago 1:04pm 20 August 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Thanks! Merged, after fixing a failing test (I guess it was just a typo) - and created 📌 Doublecheck CustomElementsRenderMarkupTest results Active for later.
- 🇦🇹Austria fago Vienna
thanks, this is merged, thus closing.
https://git.drupalcode.org/project/custom_elements/-/commit/80278bc3953f... Automatically closed - issue fixed for 2 weeks with no activity.