Values not shown on submission display when multiple items and UL used

Created on 23 May 2024, 9 months ago

Problem/Motivation

I have a multiple value name field (3 values). If I set Multiple Items "Submission display" to UL or OL, it just shows a bullet with no value.

Setting it to Table or HR works fine (but that's not the default). When viewing submissions if I use Plain text or Data (YAML) tabs, it works fine, just not when selecting "HTML". This may also be a name field issue instead.

πŸ› Bug report
Status

Active

Version

6.2

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States troybthompson

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @troybthompson
  • Please provide the YAML of a small form that exhibits the bug.

  • πŸ‡ΊπŸ‡ΈUnited States troybthompson

    It looks like it only affects name fields. I tested with text and other composite elements and all the others worked fine with multiple values:

    name:
      '#type': webform_name
      '#title': Name
      '#multiple': 3
      '#title__access': false
      '#middle__access': false
      '#suffix__access': false
      '#degree__access': false
    text:
      '#type': textfield
      '#title': Text
      '#multiple': 3
    link:
      '#type': webform_link
      '#title': Link
      '#multiple': 3
    address:
      '#type': webform_address
      '#title': Address
      '#multiple': 3
  • πŸ‡¨πŸ‡¦Canada ebremner

    I can confirm that I am receiving the same problem and here is the YAML from my form:

    langcode: en
    status: open
    dependencies: {  }
    weight: 0
    open: null
    close: null
    uid: 1
    template: false
    archive: false
    id: test
    title: Test
    description: ''
    categories: {  }
    elements: |-
      captcha:
        '#type': captcha
      name:
        '#type': webform_name
        '#title': Name
        '#multiple': true
        '#format_items': hr
        '#title__access': false
        '#middle__access': false
        '#suffix__access': false
        '#degree__access': false
    css: ''
    javascript: ''
    settings:
      ajax: false
      ajax_scroll_top: form
      ajax_progress_type: ''
      ajax_effect: ''
      ajax_speed: null
      page: true
      page_submit_path: ''
      page_confirm_path: ''
      page_theme_name: ''
      form_title: both
      form_submit_once: false
      form_open_message: ''
      form_close_message: ''
      form_exception_message: ''
      form_previous_submissions: true
      form_confidential: false
      form_confidential_message: ''
      form_disable_remote_addr: false
      form_convert_anonymous: false
      form_prepopulate: false
      form_prepopulate_source_entity: false
      form_prepopulate_source_entity_required: false
      form_prepopulate_source_entity_type: ''
      form_unsaved: false
      form_disable_back: false
      form_submit_back: false
      form_disable_autocomplete: false
      form_novalidate: false
      form_disable_inline_errors: false
      form_required: false
      form_autofocus: false
      form_details_toggle: false
      form_reset: false
      form_access_denied: page
      form_access_denied_title: ''
      form_access_denied_message: ''
      form_access_denied_attributes: {  }
      form_file_limit: ''
      form_attributes: {  }
      form_method: ''
      form_action: ''
      share: false
      share_node: false
      share_theme_name: ''
      share_title: true
      share_page_body_attributes: {  }
      submission_label: ''
      submission_exception_message: ''
      submission_locked_message: ''
      submission_log: false
      submission_excluded_elements: {  }
      submission_exclude_empty: false
      submission_exclude_empty_checkbox: false
      submission_views: {  }
      submission_views_replace: {  }
      submission_user_columns: {  }
      submission_user_duplicate: false
      submission_access_denied: default
      submission_access_denied_title: ''
      submission_access_denied_message: ''
      submission_access_denied_attributes: {  }
      previous_submission_message: ''
      previous_submissions_message: ''
      autofill: false
      autofill_message: ''
      autofill_excluded_elements: {  }
      wizard_progress_bar: true
      wizard_progress_pages: false
      wizard_progress_percentage: false
      wizard_progress_link: false
      wizard_progress_states: false
      wizard_start_label: ''
      wizard_preview_link: false
      wizard_confirmation: true
      wizard_confirmation_label: ''
      wizard_auto_forward: true
      wizard_auto_forward_hide_next_button: false
      wizard_keyboard: true
      wizard_track: ''
      wizard_prev_button_label: ''
      wizard_next_button_label: ''
      wizard_toggle: false
      wizard_toggle_show_label: ''
      wizard_toggle_hide_label: ''
      wizard_page_type: container
      wizard_page_title_tag: h2
      preview: 0
      preview_label: ''
      preview_title: ''
      preview_message: ''
      preview_attributes: {  }
      preview_excluded_elements: {  }
      preview_exclude_empty: true
      preview_exclude_empty_checkbox: false
      draft: none
      draft_multiple: false
      draft_auto_save: false
      draft_saved_message: ''
      draft_loaded_message: ''
      draft_pending_single_message: ''
      draft_pending_multiple_message: ''
      confirmation_type: inline
      confirmation_url: ''
      confirmation_title: ''
      confirmation_message: ''
      confirmation_attributes: {  }
      confirmation_back: true
      confirmation_back_label: ''
      confirmation_back_attributes: {  }
      confirmation_exclude_query: false
      confirmation_exclude_token: false
      confirmation_update: false
      limit_total: null
      limit_total_interval: null
      limit_total_message: ''
      limit_total_unique: false
      limit_user: null
      limit_user_interval: null
      limit_user_message: ''
      limit_user_unique: false
      entity_limit_total: null
      entity_limit_total_interval: null
      entity_limit_user: null
      entity_limit_user_interval: null
      purge: draft
      purge_days: 28
      results_disabled: false
      results_disabled_ignore: false
      results_customize: false
      token_view: false
      token_update: false
      token_delete: false
      serial_disabled: false
    access:
      create:
        roles:
          - anonymous
          - authenticated
        users: {  }
        permissions: {  }
      view_any:
        roles: {  }
        users: {  }
        permissions: {  }
      update_any:
        roles: {  }
        users: {  }
        permissions: {  }
      delete_any:
        roles: {  }
        users: {  }
        permissions: {  }
      purge_any:
        roles: {  }
        users: {  }
        permissions: {  }
      view_own:
        roles: {  }
        users: {  }
        permissions: {  }
      update_own:
        roles: {  }
        users: {  }
        permissions: {  }
      delete_own:
        roles: {  }
        users: {  }
        permissions: {  }
      administer:
        roles: {  }
        users: {  }
        permissions: {  }
      test:
        roles: {  }
        users: {  }
        permissions: {  }
      configuration:
        roles: {  }
        users: {  }
        permissions: {  }
    handlers: {  }
    variants: {  }
    
  • πŸ‡¨πŸ‡¦Canada ebremner

    This seems to be fixed in the latest release of webform.

  • πŸ‡¨πŸ‡¦Canada Liam Morland Ontario, CA πŸ‡¨πŸ‡¦

    Appears to have been fixed; see #5.

  • Assigned to j-barnes
  • πŸ‡ΊπŸ‡ΈUnited States j-barnes

    We are currently experiencing the same issue on the latest Webform 6.3.x-dev utilizing the name element when dealing with multiple values.

    Below is the outputted value using a dump on the submission view, so the input does exist.

    After digging a bit, you can see the below value that gets passed for rendering. The template item-list expects to receive a flat structure, so the item is never rendered. The table view uses a different composite rendering function, is unaffected by this issue.

    A simple fix to get us started is to add modifications to: docroot/modules/contrib/webform/src/Plugin/WebformElementBase.php

    if ($item) {
        $items[] = is_array($item) ? reset($item) : $item;
    }
    

    This adjustment flattens the item, allowing it to render correctly. However, further review is needed to ensure there are no unintended side effects from this change.

  • πŸ‡ΊπŸ‡ΈUnited States j-barnes
  • Pipeline finished with Failed
    about 1 month ago
    Total: 404s
    #401998
  • Pipeline finished with Canceled
    about 1 month ago
    Total: 138s
    #402171
  • Pipeline finished with Failed
    about 1 month ago
    Total: 854s
    #402174
  • Pipeline finished with Failed
    about 1 month ago
    Total: 525s
    #402225
Production build 0.71.5 2024