- Issue created by @abu-zakham
- Merge request !46Issue #3448429 by abu-zakham: Add varbase:composer-clean-up drush command to clean up composer.json → (Merged) created by abu-zakham
- Issue was unassigned.
- Status changed to Needs review
7 months ago 6:46am 21 May 2024 - Status changed to Needs work
7 months ago 10:08am 21 May 2024 - 🇯🇴Jordan Rajab Natshah Jordan
1. Let us use try catch
try { } catch (\Exception $e) { }
2. Let use the
\Drupal::logger('Varbase')
to log the fixes
3. Let use drush logger for std output from drush
3. Maybe check if the folderpatches
is in the system ( if the chmod, chown, was not right )
4. Give a warning if the Merge request was added twice- maybe it was in the composer.json file before
- then a run for
./bin/drush varbase:composer-clean-up
orlando drush varbase:composer-clean-up
fixed it - And then another patch for the same project + the same MR was added again in some way
5. Maybe more scenarios.
- 🇯🇴Jordan Rajab Natshah Jordan
Maybe we could add a flag or other command to only check if the root
composer.json
has"/-/merge_requests/"
Thank you, for the smart idea and implementation for it!
On the way for Better to ensure that our used patches are protected from any change. - Status changed to Needs review
7 months ago 1:10pm 21 May 2024 -
Rajab Natshah →
committed f62237e1 on 10.0.x authored by
abu-zakham →
Issue #3448429 by abu-zakham: Add varbase:composer-clean-up drush...
-
Rajab Natshah →
committed f62237e1 on 10.0.x authored by
abu-zakham →
-
Rajab Natshah →
committed 78cc7d07 on 9.1.x authored by
abu-zakham →
Issue #3448429 by abu-zakham: Add varbase:composer-clean-up drush...
-
Rajab Natshah →
committed 78cc7d07 on 9.1.x authored by
abu-zakham →
- 🇯🇴Jordan Rajab Natshah Jordan
Reviewed the code and merged
Optimizing the idea to follow with
Storage of Local Patches Branch
Examples of Names for Local Patch files1. Grep on
"/-/merge_requests"
not only"merge_requests"
, as it may be in the file name of a a patch.
2. Add Project name, date , issue id and the MR number.$project_name--$date--$issue_id--$mr_id.patch
- Adding the project name will ease browsing the
patches
folder. - Having the date and time will timestampe the download time to track for history or further updates
- Having the issue id is important to ready more about the issue and track status update if more changes if it got committed into a release
- Having the MR id will help when having number of MRs in the same issue
- Adding the project name will ease browsing the
- 🇯🇴Jordan Rajab Natshah Jordan
Better to print out the list of clean patches ( better drush messaging )
-
Rajab Natshah →
committed 7a8a94c0 on 9.1.x
Issue #3448429: Add varbase:composer:cleanup:patches drush command to...
-
Rajab Natshah →
committed 7a8a94c0 on 9.1.x
-
Rajab Natshah →
committed 9581ed1e on 9.1.x
Issue #3448429: Add varbase:composer:cleanup:patches drush command to...
-
Rajab Natshah →
committed 9581ed1e on 9.1.x
-
Rajab Natshah →
committed 4c6522f4 on 10.0.x
Issue #3448429: Add varbase:composer:cleanup:patches drush command to...
-
Rajab Natshah →
committed 4c6522f4 on 10.0.x
-
Rajab Natshah →
committed 3d676e8b on 10.0.x
Issue #3448429: Add varbase:composer:cleanup:patches drush command to...
-
Rajab Natshah →
committed 3d676e8b on 10.0.x
-
Rajab Natshah →
committed 79e86b73 on 9.1.x
Issue #3448429: Add varbase:composer:cleanup:patches drush command to...
-
Rajab Natshah →
committed 79e86b73 on 9.1.x
- Status changed to Fixed
7 months ago 8:28am 23 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.