- Issue created by @ptmkenny
- last update
12 months ago 30 pass, 8 fail - last update
12 months ago 30 pass, 8 fail - last update
12 months ago 30 pass, 8 fail - Status changed to Needs work
12 months ago 7:28am 20 May 2024 - last update
12 months ago 24 pass, 13 fail - last update
12 months ago 29 pass, 10 fail - last update
12 months ago 29 pass, 10 fail - π―π΅Japan ptmkenny
The drupal11 MR fixes all the issues noted by the Upgrade Status module. However, I think we still need π Automated Drupal 10 compatibility fixes RTBC , and even then, the unit tests still need to be fixed.
Also, it would be a lot easier to test this if we had π Add GitLab CI template Needs review .
- Status changed to Needs review
12 months ago 10:39am 20 May 2024 - π―π΅Japan ptmkenny
When π Compatibility with Drupal 10.2: Encrypting fields not possible in the UI RTBC is in, the unit tests will pass, so I think this is ready for review.
- π―π΅Japan ptmkenny
The Drupal 11 fixes from Updatebot included π Automated Drupal 10 compatibility fixes RTBC , so that issue can be closed if this is committed first.
- π¬π§United Kingdom alexpott πͺπΊπ
@ptmkenny with PHPStan and Drupal 11 we need to add
phpstan (next major): allow_failure: true
to .gitlab-ci.yml because we don't want to fail on D10 and it is great to know about the D11 fails / changes but we don't want to act on them yet - because we still support Drupal 10.
- π―π΅Japan ptmkenny
@alexpott Actually, I think we can fix phpstan for Drupal 11 without breaking anything for D10. There's this change record β , but since we are requiring 10.2, we can go ahead and add the new parameter to both 10 + 11.
- π―π΅Japan ptmkenny
When I run phpunit locally I'm also seeing this notice (adding a note now to take a look at this again before finalizing the MR):
Remaining self deprecation notices (2) 2x: The definition for the 'encrypt.profile.encryption_profile_2.encryption_method_configuration' sequence declares the type of its items in a way that is deprecated in drupal:8.0.0 and is removed from drupal:11.0.0. See https://www.drupal.org/node/2442603 2x in EntityHooksTest::testStatusReport from Drupal\Tests\field_encrypt\Functional
- π―π΅Japan ptmkenny
With regard to #10, this seems to be a mistake in the deprecation checker. It doesn't like this line:
'encryption_method_configuration' => ['mode' => 'CFB'],
but using a nested array to generate the value seems fine, and the tests are all passing on Drupal 11, so I think this is safe to ignore.
- π¬π§United Kingdom alexpott πͺπΊπ
Thanks @ptmkenny this looks great.
-
alexpott β
committed 6fd24905 on 3.2.x authored by
ptmkenny β
Issue #3448189 by ptmkenny: Support Drupal 11
-
alexpott β
committed 6fd24905 on 3.2.x authored by
ptmkenny β
Automatically closed - issue fixed for 2 weeks with no activity.