Contrib.social

Fix options inside styles dropdown in CKEditor5 are not fully visible

Open on Drupal.org →
Created on 19 May 2024, 6 months ago
Updated 24 June 2024, 5 months ago

Problem/Motivation

When using CKEditor 5 inside layout builder, the options for styles dropdown are very narrow resulting in the inability to visually determine the style name and look.

Steps to reproduce

  1. Go to layout builder.
  2. Add a block that uses a format where CKEditor 5 is the editor and it has a set of styles.
  3. Open the styles dropdown.
  4. Notice how options are not usable.

Proposed resolution

Exclude CKEditor from the following CSS (scss/theme/vlb-enhancements.base.scss):

#drupal-off-canvas button,
#drupal-off-canvas input[type=submit],
#layout-builder-modal button,
#layout-builder-modal input[type=submit] {
  width: auto !important;
}

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ✅ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ✅ Code review from 1 Varbase core team member
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release varbase-9.1.4, varbase_layout_builder-10.0.55 →

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • Before:

  • After:

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

🐛 Bug report
Status

Fixed

Version

10.0

Component

Code

Created by

RedwanJamous

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @RedwanJamous
  • Merge request !62Issue #3448104: Fix options inside styles dropdown in CKEditor5 are not fully visible → (Open) created by Unnamed author
  • Issue was unassigned.
  • Status changed to Needs review 6 months ago
  • Comment 6 months ago →
    RedwanJamous

    This may also apply to 10.1.x but I didn't check it.
    Adding a patch file to use with composer...

  • Pipeline finished with Success
    6 months ago
    Total: 209s
    #194952
  • Pipeline finished with Success
    6 months ago
    Total: 186s
    #194955
  • Comment 5 months ago →
    System Message
  • Status changed to Fixed 5 months ago
  • Comment 5 months ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Comment 5 months ago →
    🇯🇴Jordan Rajab Natshah Jordan
  • Pipeline finished with Manual
    5 months ago
    #202745
  • Comment 5 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    5 months ago
    Total: 186s
    #214073
  • Pipeline finished with Success
    5 months ago
    Total: 273s
    #214076
  • Pipeline finished with Success
    5 months ago
    Total: 276s
    #214081
  • Pipeline finished with Success
    5 months ago
    Total: 190s
    #214109
  • Pipeline finished with Success
    5 months ago
    Total: 228s
    #214121
  • Pipeline finished with Canceled
    5 months ago
    Total: 63s
    #217844
  • Pipeline finished with Success
    5 months ago
    Total: 230s
    #217846
  • Pipeline finished with Canceled
    5 months ago
    Total: 199s
    #217851
  • Pipeline finished with Success
    5 months ago
    Total: 223s
    #217852
  • Pipeline finished with Success
    5 months ago
    Total: 220s
    #217873
  • Pipeline finished with Success
    4 months ago
    Total: 214s
    #221532
  • Pipeline finished with Success
    4 months ago
    Total: 214s
    #221819
  • Pipeline finished with Success
    4 months ago
    Total: 217s
    #221821
  • Pipeline finished with Success
    4 months ago
    Total: 282s
    #221828
  • Pipeline finished with Success
    4 months ago
    #221911
  • Pipeline finished with Success
    4 months ago
    #221921
  • Pipeline finished with Canceled
    4 months ago
    Total: 73s
    #222627
  • Pipeline finished with Success
    4 months ago
    Total: 679s
    #222630
  • Pipeline finished with Success
    4 months ago
    Total: 645s
    #222664
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024