Fix overriding CKEditor5 styles over the used theme styles

Created on 19 May 2024, 6 months ago
Updated 30 June 2024, 5 months ago

Problem/Motivation

After updating to ckeditor5, we stopped using it as an

as it was in ckeditor4. The issue now that the stylesheets added by ckeditor5 will be applied over the entire page instead of ckeditor elements only.

Steps to reproduce

Try to add any component with a ckeditor to a content type (e.g: landing page) The ckeditor5 styles will be applied all over the page.

Proposed resolution

We have 2 proposed solutions.
  • Long term solution: To implement the usage of SDC inside CKEditor5
  • Short term solution: To call the styling files within a specific selector with a prefix for ckeditor elements.

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ➖ Automated unit/functional testing coverage
  • ➖ Developer Documentation support on feature change/addition
  • ➖ User Guide Documentation support on feature change/addition
  • ➖ UX/UI designer responsibilities
  • ➖ Accessibility and Readability
  • ❌ Code review from 1 Varbase core team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
🐛 Bug report
Status

Closed: won't fix

Version

9.0

Component

Code

Created by

🇯🇴Jordan Abdelrahman khlefat

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.71.5 2024