Links widget uses checkbox widget library

Open on Drupal.org →

Created on 17 May 2024, 4 months ago

Updated 22 July 2024, 2 months ago

Problem/Motivation

The links widget uses the checkbox-widget library, thus transforming the facet link to a span display.

In 2.x the link widget had its own library, this in now gone in 3.0. But still not sure whether the link widget should receive the checkbox widgets library. At least now this part in the template that marks a link active is now removed by the checkbox widget js and thus there is no default visual indication that a facet link is active (by CSS class, but not without class just in plain HTML).
The checkbox widget is now extending from the link widget, maybe that is the reason why the library is added to both. But this could probably be solved in using different implementation of appendWidgetLibrary in Link Widget and Checkbox Widget

There has been something about the link widget display in #3309612: Link widget styling → . Imho this is "repairing" styling for links, which in the first place got "broken" through the checkbox widget library added to the links widget.

Steps to reproduce

Use a facet with link widget and note that if you select a facet, you will not see the

(-)

indicator known from 2.x.

Proposed resolution

Do not use the checkbox widget library on the link widget. It seems, it will work without this as well and it will look and behave more like expected and like 2.x. The changes from #3309612: Link widget styling → can then be reverted too probably.

Remaining tasks

User interface changes

Back to 2.x like style and behavior for links widget

🐛 Bug report

Status

Version

3.0

Component

Code

Created by

🇩🇪Germany stefan.korn Jossgrund

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!209Links widget uses checkbox widget library
Open
🇩🇪Germany stefan.korn
updated 4 months ago

Comments & Activities

Issue created by @stefan.korn
Merge request !209Issue #3447859: Links widget uses checkbox widget library → (Open) created by stefan.korn
Status changed to Needs review 4 months ago1:26pm 17 May 2024
Comment 4 months ago →
🇩🇪Germany stefan.korn Jossgrund
Pipeline finished with Failed
4 months ago
Total: 726s
#175173
Comment 4 months ago →
🇩🇪Germany stefan.korn Jossgrund
Comment 4 months ago →
🇩🇪Germany stefan.korn Jossgrund
There is another issue if a link facet and a checkbox facet are used together. The checkbox facet js will also target links, which makes them loose styling like #3309612: Link widget styling → claims. The facet checkbox js should not target links.
Pipeline finished with Failed
4 months ago
Total: 797s
#189768
Status changed to RTBC 2 months ago1:02am 22 July 2024
Comment 2 months ago →
🇺🇸United States mlncn Minneapolis, MN, USA
Related, possible duplicate, 🐛 Links widget is loading the checkbox widget JS library Needs work , and wow i 1,000% agree with all that have worked on both issues that links should not be converted to spans by JavaScript needlessly! In addition to all the problems mentioned, it means that a theme's link stylings are not used. This is at least major and this surprisingly simple patch fixes it all, for me. Less code, much less overhead, better functionality == win.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024