- Issue created by @stefan.korn
- Merge request !209Issue #3447859: Links widget uses checkbox widget library β (Open) created by stefan.korn
- Status changed to Needs review
about 1 year ago 1:26pm 17 May 2024 - π©πͺGermany stefan.korn Jossgrund
There is another issue if a link facet and a checkbox facet are used together. The checkbox facet js will also target links, which makes them loose styling like #3309612: Link widget styling β claims. The facet checkbox js should not target links.
- Status changed to RTBC
11 months ago 1:02am 22 July 2024 - πΊπΈUnited States mlncn Minneapolis, MN, USA
Related, possible duplicate, π Links widget is loading the checkbox widget JS library Needs work , and wow i 1,000% agree with all that have worked on both issues that links should not be converted to spans by JavaScript needlessly! In addition to all the problems mentioned, it means that a theme's link stylings are not used. This is at least major and this surprisingly simple patch fixes it all, for me. Less code, much less overhead, better functionality == win.
- π³π΄Norway candalt
Can confirm that the plain diff is working fine on Drupal 10.3.10 and Facets 3.0.0.
- π«π·France S3b0uN3t Nantes
Hello,
Unlike the other two issues mentioned, I think the fix for this one is the most elegant and comprehensive.
Tested and validated in version 3.0.0 (in Drupal 11.1.3).
THANKS !
- First commit to issue fork.
- π³πΏNew Zealand ericgsmith
+1 for RTBC - this is super important to get in and a major accessibility issue
Have closed π "List of links" not working in 3.0 Active as a duplicate. This is technically a duplicate of π Links widget is loading the checkbox widget JS library Needs work which is older, although the solution here is complete and RTBC'd already.
Suggest the maintainer consider closing that and assigning credit from the related issues.
MR was showing with an unreleated test failing - have rebased and showing as green now.