Change ProjectBrowserSourceBase's option methods to be enums

Would you like a separate enum for the IDs and one for the LABELs?

No need -- enums can do __toString()!

I believe that means this...

enum Status: string
{
    case Maintained = 'Maintained';
    case Covered = 'Covered by a security policy';
    case Active = 'Active';
    case All = 'Show all';
}

.. or ...

enum Status: string
{
    case maintained = 'Maintained';
    case covered = 'Covered by a security policy';
    case active = 'Active';
    case all = 'Show all';
}

It doesn't.

The enum could be string-backed to have a string value, and implement __toString() to produce a full human-readable label.

Nah it's explicitly not supported. But looks like you can add public methods and have this:

echo Status::Covered->name; // Covered
echo Status::Covered->value; // covered
echo Status::Covered->label(); // Covered by a security policy

I did a sandbox for this which includes a __toString() commented out. If you uncomment it you get.

Fatal error: Enum Status cannot include magic method __toString in /home/user/scripts/code.php on line 4

Hmmm…maybe we just add a regular toString(), then, like the Url object has.

Ok what do you think of this? toString() felt very ambiguous, and it really would be nice to have magic __toString() support here. Either way I think it's at 95% and I'm not offended if you change the implementation.

I propose a slightly different approach: https://git.drupalcode.org/project/project_browser/-/merge_requests/493

Backed enums don't need a specialized id() method, they already have ->value to access the backing value. They really just need two things, as far as I can tell: the ability to be represented as a keyed array of translatable labels, and, well, a translatable label per-case. That's what I've implemented. Thoughts?

I rebased and added one commit to your new branch. Just a few values not replaced.

Backed enums don't need a specialized id() method, they already have ->value to access the backing value.

One way or another you would have to overload the enum. I don't think id() was any better or worse than toString() or label(). __toString() would have hidden this away for sure.

chrisfromredfin → changed the visibility of the branch 3447420-enum-options to hidden.

phenaproxima → changed the visibility of the branch 3447420-enum-options to active.

phenaproxima → changed the visibility of the branch 3447420-enum-options to hidden.

word to your mother

Automatically closed - issue fixed for 2 weeks with no activity.