- Issue created by @longwave
- Merge request !8073Resolve #3447204 "Update composer dependencies 10.3.x" β (Open) created by longwave
- Merge request !8074Resolve #3447204 "Update composer dependencies 10.4.x" β (Open) created by longwave
- Status changed to Needs review
8 months ago 10:03pm 14 May 2024 - π¬π§United Kingdom longwave UK
+------------------------------------+--------+---------+ | Production Changes | From | To | +------------------------------------+--------+---------+ | psr/http-factory | 1.0.2 | 1.1.0 | | symfony/console | v6.4.6 | v6.4.7 | | symfony/dependency-injection | v6.4.6 | v6.4.7 | | symfony/deprecation-contracts | v3.4.0 | v3.5.0 | | symfony/error-handler | v6.4.6 | v6.4.7 | | symfony/event-dispatcher | v6.4.3 | v6.4.7 | | symfony/event-dispatcher-contracts | v3.4.2 | v3.5.0 | | symfony/filesystem | v6.4.6 | v6.4.7 | | symfony/finder | v6.4.0 | v6.4.7 | | symfony/http-foundation | v6.4.4 | v6.4.7 | | symfony/http-kernel | v6.4.6 | v6.4.7 | | symfony/mailer | v6.4.6 | v6.4.7 | | symfony/mime | v6.4.6 | v6.4.7 | | symfony/process | v6.4.4 | v6.4.7 | | symfony/psr-http-message-bridge | v6.4.6 | v6.4.7 | | symfony/routing | v6.4.6 | v6.4.7 | | symfony/serializer | v6.4.6 | v6.4.7 | | symfony/service-contracts | v3.4.2 | v3.5.0 | | symfony/string | v6.4.4 | v6.4.7 | | symfony/translation-contracts | v3.4.2 | v3.5.0 | | symfony/validator | v6.4.6 | v6.4.7 | | symfony/var-dumper | v6.4.6 | v6.4.7 | | symfony/var-exporter | v6.4.6 | v6.4.7 | | symfony/yaml | v6.4.3 | v6.4.7 | | twig/twig | v3.9.3 | v3.10.2 | +------------------------------------+--------+---------+ +-----------------------------------+---------+--------+ | Dev Changes | From | To | +-----------------------------------+---------+--------+ | composer/composer | 2.7.2 | 2.7.6 | | composer/xdebug-handler | 3.0.4 | 3.0.5 | | mglaman/phpstan-drupal | 1.2.10 | 1.2.11 | | phpstan/phpdoc-parser | 1.28.0 | 1.29.0 | | phpstan/phpstan | 1.10.67 | 1.11.0 | | phpstan/phpstan-deprecation-rules | 1.1.4 | 1.2.0 | | phpstan/phpstan-phpunit | 1.3.16 | 1.4.0 | | squizlabs/php_codesniffer | 3.9.1 | 3.9.2 | | symfony/browser-kit | v6.4.3 | v6.4.7 | | symfony/css-selector | v6.4.3 | v6.4.7 | | symfony/dom-crawler | v6.4.4 | v6.4.7 | | symfony/lock | v6.4.6 | v6.4.7 | | symfony/phpunit-bridge | v6.4.6 | v6.4.7 | | webflo/drupal-finder | 1.2.2 | 1.3.0 | +-----------------------------------+---------+--------+
- π³πΏNew Zealand quietone
The only question I have here is why are there comments added to the the phpstan baseline?
- π¬π§United Kingdom longwave UK
These are "error identifiers", new in PHPStan 1.11: https://github.com/phpstan/phpstan/releases/tag/1.11.0
- Status changed to Needs work
8 months ago 6:53am 15 May 2024 - π¬π§United Kingdom longwave UK
Actually I guess I should bump the minimum version of PHPStan here.
- Status changed to Needs review
8 months ago 8:20am 15 May 2024 - π³πΏNew Zealand quietone
But why are changes needed to the baseline? There were no errors before they were added.
- π¬π§United Kingdom longwave UK
There were a couple of minor changes to the baseline where the error message has been corrected/improved:
- 'message' => '#^Call to deprecated method getConfig\\(\\) of class GuzzleHttp\\\\ClientInterface\\: + 'message' => '#^Call to deprecated method getConfig\\(\\) of interface GuzzleHttp\\\\ClientInterface\\:
This required regenerating the baseline, which now outputs the error identifiers; we should keep this in sync here otherwise we will only have to do it next time we need to regenerate the baseline because we add or remove a PHPStan-reported issue.
- Status changed to RTBC
8 months ago 11:18pm 15 May 2024 - π³πΏNew Zealand quietone
As I went to bed last night I realized that I didn't run PHPStan on all files. Once I did, I get errors, including the one above. So, yes rebuilding the baseline makes sense.
-
alexpott β
committed 06881e8e on 10.3.x
Issue #3447204 by longwave, quietone: Update Composer dependencies for...
-
alexpott β
committed 06881e8e on 10.3.x
- π¬π§United Kingdom alexpott πͺπΊπ
- Status changed to Fixed
8 months ago 7:58am 16 May 2024 -
alexpott β
committed 24e0148b on 10.4.x
Issue #3447204 by longwave, quietone: Update Composer dependencies for...
-
alexpott β
committed 24e0148b on 10.4.x
Automatically closed - issue fixed for 2 weeks with no activity.