filter-caption.html.twig shouldn't have a variable named "node"

Created on 13 May 2024, over 1 year ago

Updated 22 August 2025, 28 days ago

Problem/Motivation

See: https://api.drupal.org/api/drupal/core%21modules%21filter%21templates%21filter-caption.html.twig/11.x

It doesn't seem like a good idea to name a variable "node" if it's not related to a Drupal node. It is just extremely confusing.

Steps to reproduce

Proposed resolution

Rename this variable to something like "content" (while content is also confusing, as it's the default name of entity render arrays, but even better than "node").

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

📌 Task

Status

Active

Version

11.0 🔥

Component

Filter →

Last updated 22 days ago

No maintainer

Created by

thomas.frobieter EU

Live updates comments and jobs are added and updated live.

Merge Requests

!13060filter-caption.html.twig shouldn't have a variable named "node"
Open
Unnamed author
updated 28 days ago

Comments & Activities

Issue created by @thomas.frobieter
First commit to issue fork.
Merge request !13060Issue #3446871: Rename misleading 'node' variable to 'content' in filter-caption template. → (Open) created by Unnamed author
Pipeline finished with Failed
28 days ago
#578897
Comment 25 days ago →
🇮🇳India ajinkya45 Pune
Comment 24 days ago →
🇺🇸United States smustgrave
This will break peoples twig immediately, as can be seen by the failing tests.
Comment 24 days ago →
🇺🇸United States smustgrave
While I understand this may be confusing and I agree the dance to cover BC may not be worth it.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024