- Issue created by @kumareshbaksi
- Open on Drupal.org โCore: 10.2.x + Environment: PHP 8.1 & MySQL 5.7last update
6 months ago Waiting for branch to pass - Status changed to Needs review
6 months ago 9:15am 13 May 2024 - Status changed to RTBC
6 months ago 9:42am 13 May 2024 - ๐ฎ๐ณIndia ighosh
@kumareshbaksi Tested the patch. Looks good.
Before -
After -
+1 RTBC. - Status changed to Fixed
6 months ago 4:02pm 13 May 2024 - ๐ฎ๐ณIndia ighosh
Hi, @joseph.olstad thanks for the update and for closing this issue. However, I noticed that there was no credit given to anyone in the issue thread. Hoping for your prompt response regarding this. Thanks! :)
- ๐จ๐ฆCanada joseph.olstad
@IGhosh, I did not modify any commits, the commit messages were made by kumareshbaksi and he made the commits before anyone reviewed the code.
- ๐ช๐ธSpain fjgarlin
Note that credit is granted based on the checkboxes for credit that maintainers can update when marking the issue as fixed.
Credit is not connected to the commit messages at all.
- ๐จ๐ฆCanada joseph.olstad
@fgarlin, those checkboxes are used to create the commit message.
It is @kumareshbaksi created the commit message and made the commit in the merge request. I merged it AS-IS without redoing any commit message. - ๐ช๐ธSpain fjgarlin
Yup. I know that when clicking the checkboxes it offers you a commit message, but what i mean is that for the credit calculations, the commit message is not parsed anywhere so you can really use anything.
If you check those boxes (with the people that you want to give credit to) and save, thatโs where the real contribution credit is granted (the one that shows in user profiles).
- Status changed to Active
6 months ago 10:54pm 15 May 2024 - Status changed to Fixed
6 months ago 10:54pm 15 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.