PHP decprecation causing module action to fail

aaron.ferris → made their first commit to this issue’s fork.

Seems this config can be empty, so ive added a check for that. We may be able to get away with one of the $extensionsToAbortOn conditions further down?

@aaron.ferris thanks! I think we can do this a bit smarter, could you please check MR!32? Does it fix the issue?

Thanks @anybody, ill check it out when I can grab 5!

Tried that change, seeing the following:

The website encountered an unexpected error. Try again later.

TypeError: explode(): Argument #2 ($string) must be of type string, array given in explode() (line 484 of modules/contrib/search404/src/Controller/Search404Controller.php).

Could be my setup, originally when looking at this I assumed search404_deny_specific_file_extensions is unset for users upgrading based on the error specifically stating 'null' for parameter 2.

We could maybe have something like:

$extensionsToAbortOn = explode(' ', $this->config('search404.settings')->get('search404_deny_specific_file_extensions') ?? '');

However, this means we get an array of an empty string and thus if (!empty($extensionsToAbortOn)) { fires when we don't want to

@aaron.ferris sorry, my (stupid) mistake! Corrected!

Thanks @anybody, that looks ok to me, resolves the issue in the OP.

Thanks @aaron.ferris merged! :)

Nice thanks :)

I can confirm that release 2.2.0-rc2 solves the original issue that I raised here.
Thank you.

Automatically closed - issue fixed for 2 weeks with no activity.