Contrib.social

Adjust caching logic of LayoutBuilderAccessCheck::access()

Open on Drupal.org →
Created on 10 May 2024, about 1 year ago

Problem/Motivation

The logic of RefinableCacheableDependencyTrait::addCacheableDependency() has been updated in #3232018: Trigger an error when using \Drupal\Core\Cache\RefinableCacheableDependencyTrait::addCacheableDependency with a non CacheableDependencyInterface object → .

If the passed object is NOT an instance of CacheableDependencyInterface
Previous behavior: max-age is set to 0
Future behavior: an exception is thrown

In order to get rid of the deprecation notice and preserve the old behavior, one bit of LayoutBuilderAccessCheck::access() code was changed from

$access->addCacheableDependency($section_storage);

to

if ($section_storage instanceof CacheableDependencyInterface) {
  $access->addCacheableDependency($section_storage);
}
else {
  $access->setCacheMaxAge(0);
}

However, it was noticed that SimpleConfigSectionStorage is the only class that does not implement CacheableDependencyInterface.

Maybe SimpleConfigSectionStorage should be extended to implement CacheableDependencyInterface? Then the if condition could be removed.

Steps to reproduce

Proposed resolution

Remaining tasks

- Make a decision
- Update the code?

User interface changes

None

API changes

None

Data model changes

None

Release notes snippet

📌 Task
Status

Active

Version

11.0 🔥

Component
Layout builder  →

Last updated about 5 hours ago

Created by

leksat

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024