- Issue created by @tormi
- Assigned to abhishek_virasat
- Status changed to Needs review
8 months ago 9:37am 9 May 2024 - last update
8 months ago 7 pass, 34 fail - 🇪🇪Estonia tormi Tallinn
In this patch, I've:
- Removed the dynamic property assignments from the constructor.
- Added protected properties for each of the class variables.
- Added a setProperty() method to set properties.
- Modified the constructor to use the setProperty() method to set properties.
- last update
8 months ago 7 pass, 34 fail - Issue was unassigned.
The last submitted patch, 4: -php-82-3446220-2.patch, failed testing. View results →
The last submitted patch, 5: php-82-3446220-2.patch, failed testing. View results →
- last update
8 months ago 8 pass, 22 fail - Status changed to Needs review
8 months ago 10:31am 9 May 2024 - last update
8 months ago 7 pass, 34 fail - 🇪🇪Estonia tormi Tallinn
Added a getter method to `scald.module` to retrieve the type. Let's see what tests are saying this time.
- last update
8 months ago 12 pass, 29 fail - last update
8 months ago 15 pass, 15 fail The last submitted patch, 9: php-82-3446220-9.patch, failed testing. View results →
The last submitted patch, 10: php-82-3446220-10.patch, failed testing. View results →
- Status changed to Needs review
8 months ago 11:27am 9 May 2024 - last update
8 months ago 27 pass - 🇪🇪Estonia tormi Tallinn
Okay, this needs too much refactoring - getters and setters for every property. Let's use `AllowDynamicProperties` instead.
- last update
8 months ago 24 pass, 3 fail - last update
8 months ago 27 pass - 🇪🇪Estonia tormi Tallinn
Test classes need AllowDynamicProperties to be added as well to pass in PHP 8.2.
- last update
8 months ago 27 pass