- Issue created by @mandclu
- Status changed to Needs review
8 months ago 5:33am 9 May 2024 - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
For me, this small fix is not enough. I have an additional change I'd love to see in this fix. @mandclu may I extend your MR with it?
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
I got sign-off on this change in slack (#preview channel if you want to jump in.)
- Status changed to Fixed
8 months ago 4:34pm 10 May 2024 - Status changed to Needs work
8 months ago 8:46pm 10 May 2024 - 🇺🇸United States brianperry
Re-opening.
When enabled as part of an initial install this is fine (which unblocks this for the Starshot prototype) but I'm still seeing the original issue when later installing this in the UI or via drush. Probably not as high a priority, but still an odd install thing that we should probably get to the bottom of.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
Original issue meaning the large buttons?
- 🇺🇸United States brianperry
> Original issue meaning the large buttons?
Yup the large buttons which is a symptom of the assets for our single file components not loading.
- 🇺🇸United States cosmicdreams Minneapolis/St. Paul
In rethinking this issue. I think we're due to a refactoring of the component css. I don't think we actually need to make the svgs a variable that the component can vary.
If these buttons were reused in some key way maybe, but right now they only have a single purpose. So it makes sense to only vary the bits that make sense.
As a bonus, by providing the svg definition via a full SVG tag, we can vary the fill / background color via css. That's not something we can do with a background-image url.
- Status changed to Closed: outdated
2 months ago 3:51pm 5 November 2024 - 🇺🇸United States cosmicdreams Minneapolis/St. Paul
We've already applied this fix.