Revert 3417066 Upgrade PHPUnit to 10

I tried reverting only 📌 Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency Fixed and that resulted in tests such as core/tests/Drupal/Tests/Composer/Generator/MetapackageUpdateTest.php
failing. I tried that over at https://git.drupalcode.org/project/drupal/-/pipelines/168296/test_report....

Reverting both 📌 Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency Fixed and 📌 Upgrade PHPUnit to 10, drop Symfony PHPUnit-bridge dependency Fixed results in all tests passing.

Are we sure it wasn't 📌 PHPUnit\Runner\ErrorHandler::__construct is private since PHPUnit 11.1 Fixed that caused the issue? First report I saw of HEAD failing was 2.5 hours after that was committed. I can see this has also been reverted in this MR, so perhaps that's it?

mstrelan → closed merge request !7998

Nope, #4 didn't fix it.

Is it possible to have a link to a failing pipeline? What is actually failing?

@mondrake see https://git.drupalcode.org/issue/drupal-3446164/-/pipelines/168378, which are the same fails as elsewhere. Seems related to install profiles from what I've seen. Or more specifically umami. I'd rather fix the failure if possible than revert.

Note that WARNINGS and DEPRECATIONS in PHPUnit 10 do make the test job fail, but are not reported in the GitLab CI test summary.
You need to look at the raw log of the job failure to get details of the failure.

For example, I see in the MR failure here

PHPUnit 10.5.20 by Sebastian
Bergmann and contributors.

Runtime: PHP 8.3.6
Configuration: /builds/issue/drupal-3446164/core/phpunit.xml.dist

W 1 / 1
(100%)

HTML output was generated, 305 page(s).

Time: 01:06.504, Memory: 10.00 MB

1 test triggered 1 PHP warning:

1) /builds/issue/drupal-3446164/core/includes/install.core.inc:1805
Undefined array key "major"

Triggered by:

*
Drupal\FunctionalTests\Asset\AssetOptimizationTestUmami::testAssetAggregation

/builds/issue/drupal-3446164/core/tests/Drupal/FunctionalTests/Asset/AssetOptimizationTest.php:37

OK, but there were issues!
Tests: 1, Assertions: 240, Warnings: 1.

FYI, catch has been looking into this and has reverted 🐛 Composer tests fail because of invalid Drupal version Fixed .

#11 is this won't fix then? RTBC to get a core committer decide.

Experiments are ongoing over in 🐛 Composer tests fail because of invalid Drupal version Fixed , we don't think it is directly PHPUnit 10 - it's (partially?) something to do with translation downloads, but I don't think this should entirely be rolled back so marking as postponed on that issue for now.

The issue that started this was fixed AFAICS.

quietone → closed merge request !7996